Page MenuHomePhabricator
Differential D9443

Applied various linter fixes.
ClosedPublic
Actions

Authored by joshuaspence on Jun 9 2014, 10:27 PM.
Tags
None
Referenced Files
F13274341: D9443.diff
Fri, May 31, 3:35 AM
F13259373: D9443.id22544.diff
Sun, May 26, 7:51 PM
F13230664: D9443.id22544.diff
Mon, May 20, 11:14 PM
F13219352: D9443.id.diff
Sat, May 18, 5:42 PM
F13181131: D9443.id22546.diff
Thu, May 9, 9:01 AM
F13181130: D9443.id22544.diff
Thu, May 9, 9:01 AM
Unknown Object (File)
Tue, May 7, 8:15 AM
Unknown Object (File)
Fri, May 3, 8:54 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPd0128afa2908: Applied various linter fixes.
Summary

Applied some more linter fixes that I previously missed because my global arc install was out-of-date.

Test Plan

Will run arc unit on another host.

Diff Detail

Repository
rP Phabricator
Branch
lintfix
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 945
Build 945: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22544.Jun 9 2014, 10:27 PM
joshuaspence retitled this revision from to Applied various linter fixes..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 9 2014, 10:27 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B945: Diff 22544.Jun 9 2014, 10:28 PM
epriestley accepted this revision.Jun 9 2014, 11:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 9 2014, 11:03 PM
epriestley closed this revision.Jun 9 2014, 11:04 PM
epriestley updated this revision to Diff 22546.

Closed by commit rPd0128afa2908 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
sql/
patches/
2 lines
scripts/
aphront/
2 lines
symbols/
2 lines
src/
aphront/
26 lines
applications/
audit/
editor/
4 lines
auth/
provider/
2 lines
chatlog/
controller/
8 lines
conduit/
call/
4 lines
config/
controller/
2 lines
conpherence/
controller/
4 lines
view/
4 lines
dashboard/
controller/
2 lines
differential/
4 lines
editor/
2 lines
landing/
6 lines
mail/
4 lines
parser/
8 lines
__tests__/
data/
1 line
1 line
1 line
view/
2 lines
diffusion/
protocol/
__tests__/
2 lines
request/
4 lines
view/
2 lines
feed/
conduit/
2 lines
herald/
adapter/
2 lines
controller/
2 lines
meta/
controller/
4 lines
metamta/
parser/
__tests__/
4 lines
replyhandler/
2 lines
owners/
conduit/
8 lines
mail/
2 lines
4 lines
query/
4 lines
pholio/
query/
6 lines
phrequent/
controller/
2 lines
project/
controller/
2 lines
releeph/
controller/
product/
2 lines
request/
2 lines
settings/
panel/
4 lines
infrastructure/
daemon/
bot/
handler/
8 lines
sms/
adapter/
2 lines
view/
control/
6 lines
layout/
2 lines

Diff 22544

View Options

resources/sql/patches/098.heraldruletypemigration.php

Loading...
View Options

scripts/aphront/aphrontpath.php

Loading...
View Options

scripts/symbols/generate_ctags_symbols.php

Loading...
View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth.php

Loading...
View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

Loading...
View Options

src/applications/conduit/call/ConduitCall.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIgnoreController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceWidgetController.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardViewController.php

Loading...
View Options

src/applications/differential/DifferentialGetWorkingCopy.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/landing/DifferentialLandingToHostedGit.php

Loading...
View Options

src/applications/differential/mail/DifferentialReplyHandler.php

Loading...
View Options

src/applications/differential/parser/DifferentialHunkParser.php

Loading...
View Options

src/applications/differential/parser/__tests__/data/missing_context.diff

Loading...
View Options

src/applications/differential/parser/__tests__/data/missing_context_2.diff

Loading...
View Options

src/applications/differential/parser/__tests__/data/missing_context_3.diff

Loading...
View Options

src/applications/differential/view/DifferentialInlineCommentView.php

Loading...
View Options

src/applications/diffusion/protocol/__tests__/DiffusionSubversionWireProtocolTestCase.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/diffusion/view/DiffusionView.php

Loading...
View Options

src/applications/feed/conduit/ConduitAPI_feed_query_Method.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

Loading...
View Options

src/applications/metamta/parser/__tests__/PhabricatorMetaMTAEmailBodyParserTestCase.php

Loading...
View Options

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Loading...
View Options

src/applications/owners/conduit/ConduitAPI_owners_query_Method.php

Loading...
View Options

src/applications/owners/mail/PackageMail.php

Loading...
View Options

src/applications/owners/mail/PackageModifyMail.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnerPathQuery.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/phrequent/controller/PhrequentTrackController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditIconController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductEditController.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestEditController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php

Loading...
View Options

src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php

Loading...
View Options

src/infrastructure/sms/adapter/PhabricatorSMSImplementationTwilioAdapter.php

Loading...
View Options

src/view/control/AphrontCursorPagerView.php

Loading...
View Options

src/view/layout/PhabricatorSourceCodeView.php

Loading...
Phabricator · Built by Phacility