Page MenuHomePhabricator

Make Aphlict errors persistent.
ClosedPublic

Authored by joshuaspence on Jun 7 2014, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 18 2025, 12:56 AM
Unknown Object (File)
Apr 15 2025, 4:35 AM
Unknown Object (File)
Apr 8 2025, 8:20 PM
Unknown Object (File)
Apr 8 2025, 12:23 AM
Unknown Object (File)
Apr 5 2025, 3:26 AM
Unknown Object (File)
Apr 4 2025, 8:19 PM
Unknown Object (File)
Mar 20 2025, 2:05 AM
Unknown Object (File)
Mar 16 2025, 4:08 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPbb6fb249666d: Make Aphlict errors persistent.
Summary

Since an error is bad and means that some sort of action is required, make Aphlict error notifications persistent (i.e. they won't dismiss until being clicked).

Test Plan

Loaded a page with notifications.enabled set to true but without the Aphlict server actually running. Noticed that the error message didn't dismiss automatically.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Make Aphlict errors persistent..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 9 2014, 6:43 PM
epriestley updated this revision to Diff 22525.

Closed by commit rPbb6fb249666d (authored by @joshuaspence, committed by @epriestley).