Page MenuHomePhabricator

Try `nodejs` before `node` when starting notification server
ClosedPublic

Authored by epriestley on Jun 7 2014, 8:14 PM.
Tags
None
Referenced Files
F14045203: D9419.diff
Wed, Nov 13, 2:10 AM
F14033389: D9419.id.diff
Sat, Nov 9, 5:35 PM
F14032876: D9419.id.diff
Sat, Nov 9, 4:05 PM
F13984520: D9419.id22493.diff
Sun, Oct 20, 1:58 PM
F13979783: D9419.id22498.diff
Sat, Oct 19, 6:31 AM
F13963882: D9419.id.diff
Tue, Oct 15, 6:29 PM
Unknown Object (File)
Oct 9 2024, 9:44 PM
Unknown Object (File)
Oct 8 2024, 3:03 PM
Subscribers

Details

Summary

Fixes T5278. This isn't completely perfect (if you have the other node binary, it will fail to detect that it's wrong) but we can maybe wait for that to happen and devise some kind of "is this binary really node?" test if users actually hit it.

Test Plan

Faked things, hit the error; unfaked them and hit the normal flow.

Diff Detail

Repository
rP Phabricator
Branch
nodebin
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 919
Build 919: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Try `nodejs` before `node` when starting notification server.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
  • Remove "\$" from single-quoted string.
This revision is now accepted and ready to land.Jun 7 2014, 8:54 PM
epriestley updated this revision to Diff 22498.

Closed by commit rP39ca090d154b (authored by @epriestley).