Page MenuHomePhabricator

Try `nodejs` before `node` when starting notification server
ClosedPublic

Authored by epriestley on Jun 7 2014, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 5:00 AM
Unknown Object (File)
Thu, Nov 14, 5:04 AM
Unknown Object (File)
Wed, Nov 13, 2:10 AM
Unknown Object (File)
Sat, Nov 9, 5:35 PM
Unknown Object (File)
Sat, Nov 9, 4:05 PM
Unknown Object (File)
Oct 20 2024, 1:58 PM
Unknown Object (File)
Oct 19 2024, 6:31 AM
Unknown Object (File)
Oct 15 2024, 6:29 PM
Subscribers

Details

Summary

Fixes T5278. This isn't completely perfect (if you have the other node binary, it will fail to detect that it's wrong) but we can maybe wait for that to happen and devise some kind of "is this binary really node?" test if users actually hit it.

Test Plan

Faked things, hit the error; unfaked them and hit the normal flow.

Diff Detail

Repository
rP Phabricator
Branch
nodebin
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 919
Build 919: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Try `nodejs` before `node` when starting notification server.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
  • Remove "\$" from single-quoted string.
This revision is now accepted and ready to land.Jun 7 2014, 8:54 PM
epriestley updated this revision to Diff 22498.

Closed by commit rP39ca090d154b (authored by @epriestley).