Differential D9379

Changed behavior of "code block" button to use triple tick syntax ("```") instead of whitespacing.
ClosedPublic
Actions

Authored by talshiri on Jun 4 2014, 10:38 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPb6748034f030: Changed behavior of "code block" button to use triple tick syntax ("```")…

Summary

This is important when dealing in situations where there's ambiguity between code and lists, like with Objective-C code:

(void) foobar {}

will get your a list instead of the desired code block

Test Plan

Tested locally

Diff Detail

Repository

rP Phabricator

Branch

code_block_triple_tick

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 853
Build 853: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri updated this revision to Diff 22352.Jun 4 2014, 10:38 PM

talshiri retitled this revision from to Changed behavior of "code block" button to use triple tick syntax ("```") instead of whitespacing..

talshiri updated this object.

talshiri edited the test plan for this revision. (Show Details)

talshiri added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 4 2014, 10:38 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B853: Diff 22352.Jun 4 2014, 10:39 PM

Yeah, this is confusing for other reasons too, I've been meaning to do this for a while. Thanks!

This revision is now accepted and ready to land.Jun 4 2014, 10:39 PM

Closed by commit rPb6748034f030 (authored by @talshiri, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

26 lines

webroot/

rsrc/

js/

core/

behavior-phabricator-remarkup-assist.js

5 lines

Diff 22352

View Options

resources/celerity/map.php