Page MenuHomePhabricator
Differential D9363

Don't redraw the console progress bar every time
ClosedPublic
Actions

Authored by epriestley on Jun 3 2014, 6:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:47 PM
Unknown Object (File)
Wed, Apr 24, 11:41 AM
Unknown Object (File)
Wed, Apr 24, 3:40 AM
Unknown Object (File)
Thu, Apr 11, 1:08 PM
Unknown Object (File)
Thu, Apr 11, 10:01 AM
Unknown Object (File)
Tue, Apr 2, 8:36 AM
Unknown Object (File)
Mar 29 2024, 5:57 AM
Unknown Object (File)
Mar 21 2024, 6:49 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
Maniphest Tasks
T5255: Batch up SQL operations in the `./bin/repository parents` script
Commits
rPHU1e025a87a4cb: Don't redraw the console progress bar every time
Summary

lulululuul see D9361

Test Plan

derp derp derp

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22294.Jun 3 2014, 6:20 PM
epriestley retitled this revision from to Don't redraw the console progress bar every time.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 3 2014, 6:20 PM
epriestley updated this revision to Diff 22295.Jun 3 2014, 6:21 PM
  • Only set lastUpdate if we actually draw.
Harbormaster completed remote builds in B829: Diff 22294.Jun 3 2014, 6:21 PM
Harbormaster completed remote builds in B830: Diff 22295.
epriestley updated this revision to Diff 22296.Jun 3 2014, 6:22 PM
  • Slightly smoother bar (100ms / update instead of 200ms).
Harbormaster completed remote builds in B831: Diff 22296.Jun 3 2014, 6:23 PM
joshuaspence accepted this revision.Jun 3 2014, 6:24 PM
joshuaspence edited edge metadata.

LGTM.

This makes the progress bar a little jerky, but I'd rather the progress bar be jerky than have the ./bin/repository parents script run 127 times slower.

This revision is now accepted and ready to land.Jun 3 2014, 6:24 PM
epriestley closed this revision.Jun 3 2014, 6:26 PM
epriestley updated this revision to Diff 22297.

Closed by commit rPHU1e025a87a4cb (authored by @epriestley).

joshuaspence added a comment.Jun 3 2014, 6:28 PM

Thanks for the fix

epriestley mentioned this in D19506: Add --quiet flag to rebuild-identities.Aug 2 2018, 4:14 PM

Revision Contents
Changeset List

PathSize
src/
console/
8 lines

Diff 22297

View Options

src/console/PhutilConsoleProgressBar.php

Loading...
Phabricator · Built by Phacility