repository parents` workflow.
AbandonedPublic
Actions

Authored by joshuaspence on Jun 3 2014, 4:30 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5242: `./bin/repository parents` should provide a `--background` option.

Summary

Fixes T5242. Add a --background option to the ./bin/repository parents workflow such that the heavy lifting will be handled by a PhabricatorWorker in the task queue.

Test Plan

Not yet tested.

Diff Detail

Repository

rP Phabricator

Branch

repo_parents-background

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 824
Build 824: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22285.Jun 3 2014, 4:30 PM

joshuaspence retitled this revision from to Add a `--background` option to the `./bin/repository parents` workflow..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5242: `./bin/repository parents` should provide a `--background` option..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 3 2014, 4:30 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B822: Diff 22285.Jun 3 2014, 4:31 PM

Can we just batch all the queries instead? Instead of running the deletes/inserts inline, queue them into $delete_sql and $insert_sql, then execute them in chunks. And maybe even batch the selects. I'd guess that will make this run many hundreds of times faster, not require all the daemon complexity and overhead, and be better for everyone.

Minor fix.

Harbormaster completed remote builds in B824: Diff 22287.Jun 3 2014, 4:41 PM

In D9359#7, @epriestley wrote:

Can we just batch all the queries instead? Instead of running the deletes/inserts inline, queue them into $delete_sql and $insert_sql, then execute them in chunks. And maybe even batch the selects. I'd guess that will make this run many hundreds of times faster, not require all the daemon complexity and overhead, and be better for everyone.

Yeah, you're probably right.

joshuaspence abandoned this revision.Jun 3 2014, 5:06 PM