Differential D9354

Explicitly enable strict compilation for the Aphlict client SWF.
ClosedPublic
Actions

Authored by joshuaspence on Jun 3 2014, 2:01 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPb01f57bfdbc8: Explicitly enable strict compilation for the Aphlict client SWF.

Summary

Strict mode is enabled by default, but it would be best to explicitly enable it... just in case.

Strict mode prints undefined property and function calls; also performs compile-time type checking on assignments and options supplied to method calls. See http://help.adobe.com/en_US/flex/using/WS2db454920e96a9e51e63e3d11c0bf69084-7a92.html

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Branch

aphlict-strict

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 815
Build 815: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22277.Jun 3 2014, 2:01 AM

joshuaspence retitled this revision from to Explicitly enable strict compilation for the Aphlict client SWF..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 3 2014, 2:01 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B815: Diff 22277.Jun 3 2014, 2:02 AM

epriestley accepted this revision.Jun 3 2014, 1:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2014, 1:10 PM

Closed by commit rPb01f57bfdbc8 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

support/

aphlict/

client/

build_aphlict_client.sh

1 line

Diff 22277

View Options

support/aphlict/client/build_aphlict_client.sh

Explicitly enable strict compilation for the Aphlict client SWF.ClosedPublicActions