Page MenuHomePhabricator
Differential D9340

Implement PhabricatorProjectInterface for marking that objects can be tagged with projects
ClosedPublic
Actions

Authored by epriestley on May 30 2014, 11:24 PM.
Tags
None
Referenced Files
F14096641: D9340.id22323.diff
Tue, Nov 26, 4:32 AM
Unknown Object (File)
Sun, Nov 24, 11:17 PM
Unknown Object (File)
Thu, Nov 21, 12:09 AM
Unknown Object (File)
Sun, Nov 17, 7:44 AM
Unknown Object (File)
Wed, Nov 13, 10:41 PM
Unknown Object (File)
Fri, Nov 8, 4:53 PM
Unknown Object (File)
Mon, Nov 4, 10:10 AM
Unknown Object (File)
Sat, Nov 2, 6:44 AM
View All Files
Subscribers
epriestley
Tokens
"Doubloon" token, awarded by chad.

Details

Reviewers
btrahan
Maniphest Tasks
T5245: Migrate Maniphest Projects to use edge infrastructure
T2628: Add project tags to Pholio, Ponder, Differential, and other applications
Commits
Restricted Diffusion Commit
rP4cda3e5811c0: Implement PhabricatorProjectInterface for marking that objects can be tagged…
Summary

Ref T2628. This makes Transactions understand objects that can have project relationships, extract project mentions, and handle watching.

Test Plan

See next diff.

Diff Detail

Repository
rP Phabricator
Branch
projectif1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1937XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 795
Build 795: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22249.May 30 2014, 11:24 PM
epriestley retitled this revision from to Implement PhabricatorProjectInterface for marking that objects can be tagged with projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2628: Add project tags to Pholio, Ponder, Differential, and other applications.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 30 2014, 11:24 PM
Harbormaster completed remote builds in B795: Diff 22249.May 30 2014, 11:26 PM
chad awarded a token.May 30 2014, 11:26 PM
epriestley added a comment.May 30 2014, 11:36 PM

(D9341 has some screenshots, I just broke it out so it can serve as a better template for T1906.)

btrahan accepted this revision.Jun 3 2014, 10:02 PM
btrahan edited edge metadata.

another great diff

src/applications/project/interface/PhabricatorProjectInterface.php
3–5

nice

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
1937

is there a tracking task we can reference for good grepping?

This revision is now accepted and ready to land.Jun 3 2014, 10:02 PM
epriestley closed this revision.Jun 4 2014, 12:19 AM
epriestley updated this revision to Diff 22323.

Closed by commit rP4cda3e5811c0 (authored by @epriestley).

epriestley added a comment.Jun 4 2014, 12:20 AM

Oh -- T5245 is maybe a reasonable task.

Revision Contents
Changeset List

PathSize
src/
3 lines
applications/
project/
application/
6 lines
events/
59 lines
interface/
5 lines
transactions/
editor/
48 lines
infrastructure/
markup/
rule/
7 lines

Diff 22249

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/application/PhabricatorApplicationProject.php

Loading...
View Options

src/applications/project/events/PhabricatorProjectUIEventListener.php

Loading...
View Options

src/applications/project/interface/PhabricatorProjectInterface.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php

Loading...
Phabricator · Built by Phacility