Page MenuHomePhabricator

Add a `./bin/aphlict build` workflow.
ClosedPublic

Authored by joshuaspence on May 30 2014, 9:54 AM.
Tags
None
Referenced Files
F13245949: D9338.id22479.diff
Thu, May 23, 6:54 AM
F13226623: D9338.id22244.diff
Sun, May 19, 10:04 PM
F13215947: D9338.id.diff
Fri, May 17, 9:12 PM
F13202568: D9338.diff
Tue, May 14, 10:51 PM
F13191631: D9338.diff
Sat, May 11, 11:04 PM
F13175928: D9338.diff
Wed, May 8, 8:55 AM
Unknown Object (File)
Sat, May 4, 1:12 AM
Unknown Object (File)
Apr 24 2024, 11:19 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPddf5412cbbfd: Add a `./bin/aphlict build` workflow.
Summary

Currently, it is a bit tricky to build the Aphlict client SWF from the ActionScript source. Provide a ./bin/aphlict build workflow that simplifies this process.

Depends on D9226.

Test Plan

Executed the workflow:

> ./bin/aphlict build
Done.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Add a `./bin/aphlict build` workflow..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Does this need the --strict flag too now?

One thing I really hate (not quite related to this diff) is that the build process is not idempotent.

epriestley edited edge metadata.

Summarizing from IRC:

  • mxmlc embeds some kind of timestamp or something into the binaries.
  • gzuncompress()'ing the .SWF after stripping the header gives binaries differing by 3 bytes in a nonobvious way (i.e., not an easily identifiable timestamp in an XML section or anything like that).
  • -raw-metadata '' didn't get rid of this either.
  • Least bad way forward for now seems to be just living with it.
This revision is now accepted and ready to land.Jun 7 2014, 6:33 PM
epriestley updated this revision to Diff 22479.

Closed by commit rPddf5412cbbfd (authored by @joshuaspence, committed by @epriestley).