Page MenuHomePhabricator
Differential D9332

Remove application small/hidden tiles
ClosedPublic
Actions

Authored by epriestley on May 29 2014, 9:31 PM.
Tags
None
Referenced Files
F15483009: D9332.id22231.diff
Wed, Apr 9, 9:13 AM
F15465798: D9332.id22234.diff
Wed, Apr 2, 11:20 PM
F15465353: D9332.id22231.diff
Wed, Apr 2, 5:44 PM
F15465244: D9332.id.diff
Wed, Apr 2, 4:27 PM
F15463409: D9332.diff
Tue, Apr 1, 11:09 PM
F15448773: D9332.id.diff
Fri, Mar 28, 6:49 AM
F15433896: D9332.diff
Tue, Mar 25, 1:05 AM
F15430797: D9332.diff
Mon, Mar 24, 9:00 AM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5176: Remove small application tiles on the homepage?
Commits
Restricted Diffusion Commit
rP24eacaa032ad: Remove application small/hidden tiles
Summary

Ref T5176. This paves the way for the redesign by making the homepage editor thing a little more manageable/coherent.

Not perfect, but we can clean it up a bit after the new design.

Test Plan

Home page:

Screen_Shot_2014-05-29_at_2.29.24_PM.png (930×1 px, 210 KB)

New "Pinned Applications" settings panel (this supports drag-and-drop to reorder):

Screen_Shot_2014-05-29_at_2.29.29_PM.png (930×1 px, 193 KB)

Pin an app:

Screen_Shot_2014-05-29_at_2.29.42_PM.png (930×1 px, 178 KB)

Unpin an app:

Screen_Shot_2014-05-29_at_2.29.37_PM.png (930×1 px, 179 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22231.May 29 2014, 9:31 PM
epriestley retitled this revision from to Remove application small/hidden tiles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T5176: Remove small application tiles on the homepage?.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 29 2014, 9:31 PM
Harbormaster completed remote builds in B784: Diff 22231.May 29 2014, 9:32 PM
chad edited edge metadata.May 29 2014, 9:54 PM

This isn't perfect, but we can clean it up after the redesign.

chad accepted this revision.May 29 2014, 9:56 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 29 2014, 9:56 PM
epriestley closed this revision.May 29 2014, 10:04 PM
epriestley updated this revision to Diff 22234.

Closed by commit rP24eacaa032ad (authored by @epriestley).

joshuaspence added a subscriber: joshuaspence.May 29 2014, 10:20 PM

Did this diff change the color fo the sidebar? It seems very off at the moment.

sidebar.png (684×203 px, 24 KB)

chad added a comment.May 29 2014, 10:22 PM

we're rolling out a redesign branch to secure, so there may be some missed features. Will add that to my stack.

chad added a comment.May 29 2014, 10:25 PM

T5224

joshuaspence added a comment.May 29 2014, 10:27 PM
In D9332#14, @chad wrote:

we're rolling out a redesign branch to secure, so there may be some missed features. Will add that to my stack.

Gotcha, thanks

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
home/
controller/
127 lines
settings/
panel/
307 lines
storage/
28 lines
view/
form/
control/
22 lines
webroot/
rsrc/
css/
application/
settings/
js/
core/
37 lines

Diff 22234

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/view/form/control/AphrontFormSelectControl.php

Loading...
View Options

webroot/rsrc/css/application/settings/settings.css

Loading...
View Options

webroot/rsrc/js/core/behavior-reorder-applications.js

Loading...
Phabricator · Built by Phacility