Page MenuHomePhabricator

Allow `FileFinder` to find paths which match a given path exactly.
ClosedPublic

Authored by joshuaspence on May 25 2014, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 4:48 AM
Unknown Object (File)
Sun, Dec 15, 4:48 AM
Unknown Object (File)
Sun, Dec 15, 4:48 AM
Unknown Object (File)
Sun, Dec 15, 4:30 AM
Unknown Object (File)
Sun, Dec 15, 4:13 AM
Unknown Object (File)
Sat, Dec 14, 3:44 PM
Unknown Object (File)
Sat, Dec 14, 2:26 AM
Unknown Object (File)
Fri, Dec 13, 11:44 AM
Subscribers

Details

Summary

Ref T5105. This functionality is required in order to discover all .editorconfig files.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Allow `FileFinder` to find paths which match a given path exactly..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Two janitorial inlines.

src/filesystem/FileFinder.php
111–117

pls 2 clarifying parens T.T

or count() || count()?

227

This should probably be array_merge()? The initial elements of suffix will be overwritten:

$ php -r "print_r(array('example.js') + array('.js'));"
Array
(
    [0] => example.js
)
This revision now requires changes to proceed.May 26 2014, 5:25 PM
joshuaspence edited edge metadata.

Minor changes, as requested by @epriestley

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 27 2014, 11:36 PM
epriestley updated this revision to Diff 22097.

Closed by commit rPHUefa928f70307 (authored by @joshuaspence, committed by @epriestley).