Page MenuHomePhabricator
Differential D9288

Use DiffQuery instead of direct hunk loads in MessageParser daemon
ClosedPublic
Actions

Authored by epriestley on May 25 2014, 3:24 PM.
Tags
None
Referenced Files
F13130878: D9288.diff
Wed, May 1, 12:44 PM
Unknown Object (File)
Sun, Apr 28, 8:38 AM
Unknown Object (File)
Thu, Apr 25, 12:00 PM
Unknown Object (File)
Thu, Apr 25, 4:09 AM
Unknown Object (File)
Thu, Apr 25, 2:30 AM
Unknown Object (File)
Wed, Apr 24, 11:48 PM
Unknown Object (File)
Sat, Apr 20, 6:56 PM
Unknown Object (File)
Fri, Apr 19, 6:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt
Commits
Restricted Diffusion Commit
rPcb58acbe5bcd: Use DiffQuery instead of direct hunk loads in MessageParser daemon
Summary

Ref T5179. Ref T4045. Continue reducing the number of direct hunk loads we perform.

Test Plan

Pushed a closing commit, used scripts/repository/reparse.php --message ... to trigger this logic, got a sensible/accurate result.

Diff Detail

Repository
rP Phabricator
Branch
hunk3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 696
Build 696: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22053.May 25 2014, 3:24 PM
epriestley retitled this revision from to Use DiffQuery instead of direct hunk loads in MessageParser daemon.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5179: Unearth Differential rendering technical debt, T4045: Store diffs as binary, not UTF-8.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2014, 3:24 PM
Harbormaster completed remote builds in B696: Diff 22053.May 25 2014, 3:25 PM
btrahan accepted this revision.Jun 3 2014, 10:11 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:11 PM
epriestley closed this revision.Jun 4 2014, 1:03 AM
epriestley updated this revision to Diff 22327.

Closed by commit rPcb58acbe5bcd (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
worker/
commitmessageparser/
28 lines

Diff 22053

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility