Page MenuHomePhabricator

Move more hunk loads into DifferentialHunkQuery
ClosedPublic

Authored by epriestley on May 25 2014, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 11:58 AM
Unknown Object (File)
Feb 4 2024, 3:48 AM
Unknown Object (File)
Feb 4 2024, 3:47 AM
Unknown Object (File)
Jan 18 2024, 9:49 AM
Unknown Object (File)
Jan 15 2024, 10:05 PM
Unknown Object (File)
Jan 15 2024, 10:05 PM
Unknown Object (File)
Jan 15 2024, 7:41 PM
Unknown Object (File)
Dec 22 2023, 8:04 AM
Subscribers

Details

Summary

Ref T5179. Ref T4045. I want to move all hunk loads into DifferentialHunkQuery so I can make it do magical things where hunks come from multiple places, handle non-utf8 encodings properly, handle compression, archive into Files, and so on.

Test Plan

Viewed some revisions. Called differential.getrawdiff.

Diff Detail

Repository
rP Phabricator
Branch
hunk2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialChangeset.php:188XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 695
Build 695: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Move more hunk loads into DifferentialHunkQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:10 PM
epriestley updated this revision to Diff 22326.

Closed by commit rP71e9fb96b56e (authored by @epriestley).