Page MenuHomePhabricator
Differential D9287

Move more hunk loads into DifferentialHunkQuery
ClosedPublic
Actions

Authored by epriestley on May 25 2014, 3:11 PM.
Tags
None
Referenced Files
F18108860: D9287.id.diff
Mon, Aug 11, 9:57 AM
F18108452: D9287.id22052.diff
Mon, Aug 11, 7:04 AM
F18103514: D9287.id22326.diff
Sun, Aug 10, 6:04 AM
F17942239: D9287.id22326.diff
Thu, Jul 31, 6:32 AM
F17868849: D9287.diff
Mon, Jul 28, 9:55 AM
Unknown Object (File)
Jun 30 2025, 5:02 AM
Unknown Object (File)
Jun 17 2025, 8:29 AM
Unknown Object (File)
Jun 17 2025, 8:09 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt
Commits
Restricted Diffusion Commit
rP71e9fb96b56e: Move more hunk loads into DifferentialHunkQuery
Summary

Ref T5179. Ref T4045. I want to move all hunk loads into DifferentialHunkQuery so I can make it do magical things where hunks come from multiple places, handle non-utf8 encodings properly, handle compression, archive into Files, and so on.

Test Plan

Viewed some revisions. Called differential.getrawdiff.

Diff Detail

Repository
rP Phabricator
Branch
hunk2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialChangeset.php:188XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 695
Build 695: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22052.May 25 2014, 3:11 PM
epriestley retitled this revision from to Move more hunk loads into DifferentialHunkQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5179: Unearth Differential rendering technical debt, T4045: Store diffs as binary, not UTF-8.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2014, 3:11 PM
Harbormaster completed remote builds in B695: Diff 22052.May 25 2014, 3:13 PM
btrahan accepted this revision.Jun 3 2014, 10:10 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:10 PM
epriestley closed this revision.Jun 4 2014, 1:03 AM
epriestley updated this revision to Diff 22326.

Closed by commit rP71e9fb96b56e (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
differential/
conduit/
16 lines
parser/
__tests__/
21 lines
query/
33 lines
render/
4 lines
storage/
28 lines

Diff 22052

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_getrawdiff_Method.php

Loading...
View Options

src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php

Loading...
View Options

src/applications/differential/query/DifferentialDiffQuery.php

Loading...
View Options

src/applications/differential/render/DifferentialRawDiffRenderer.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
Phabricator · Built by Phacility