Page MenuHomePhabricator
Differential D9265

Add a `version` workflow to arcanist.
ClosedPublic
Actions

Authored by joshuaspence on May 23 2014, 12:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 3:50 PM
Unknown Object (File)
Tue, Dec 24, 5:13 PM
Unknown Object (File)
Sat, Dec 21, 4:20 PM
Unknown Object (File)
Sat, Dec 21, 4:19 PM
Unknown Object (File)
Sat, Dec 21, 4:19 PM
Unknown Object (File)
Sat, Dec 21, 4:19 PM
Unknown Object (File)
Sat, Dec 21, 3:36 PM
Unknown Object (File)
Sun, Dec 15, 5:14 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCb7bb6c834830: Add a `version` workflow to arcanist.
Summary

A version workflow would be useful, especially for less technical users. Additionally, whenever I am faced with a new command I reasonably expect $CMD [--help|help] and $CMD [--version|version] to work.

Test Plan

Ran arc version.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22003.May 23 2014, 12:55 PM
joshuaspence retitled this revision from to Add a `version` workflow to arcanist..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 23 2014, 12:55 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B664: Diff 22003.May 23 2014, 12:57 PM
joshuaspence updated this revision to Diff 22006.May 23 2014, 2:22 PM
joshuaspence edited edge metadata.

Show timestamp as well.

joshuaspence added a parent revision: D9267: Add a `getWorkingCopyTimestamp` function to `ArcanistRepositoryAPI`..May 23 2014, 2:23 PM
Harbormaster completed remote builds in B667: Diff 22006.May 23 2014, 2:23 PM
epriestley requested changes to this revision.May 23 2014, 4:13 PM
epriestley edited edge metadata.

See D9267, mostly.

Otherwise, if any of the paths are not git working copies or the git binary is not available on the system, we should recover gracefully. arc upgrade has a check for the former, although both workflows should probably check both.

This revision now requires changes to proceed.May 23 2014, 4:13 PM
joshuaspence updated this revision to Diff 22027.May 24 2014, 2:07 AM
joshuaspence edited edge metadata.
  • Simplify logic for determining the commit timestamp.
  • Fail gracefully if git is missing.
  • Fail gracefully if the .git directory does not exist.
joshuaspence added a comment.May 24 2014, 2:07 AM

This is what the output looks like:

> arc version
arcanist 635f49dc5466979d2ddef02269c512c2aff912c2 (24 May 2014)
libphutil 1add454ccdb7a23bd8d1823452c570bf2ae445e0 (19 May 2014)
Harbormaster completed remote builds in B677: Diff 22027.May 24 2014, 2:08 AM
epriestley accepted this revision.May 24 2014, 2:35 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 24 2014, 2:35 AM
epriestley closed this revision.May 24 2014, 2:35 AM
epriestley updated this revision to Diff 22028.

Closed by commit rARCb7bb6c834830 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
workflow/
61 lines

Diff 22028

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/workflow/ArcanistVersionWorkflow.php

Loading...
Phabricator · Built by Phacility