Page MenuHomePhabricator

Add a `version` workflow to arcanist.
ClosedPublic

Authored by joshuaspence on May 23 2014, 12:55 PM.
Tags
None
Referenced Files
F13975922: D9265.diff
Fri, Oct 18, 12:13 PM
F13958156: D9265.diff
Mon, Oct 14, 1:15 PM
Unknown Object (File)
Sep 15 2024, 1:41 AM
Unknown Object (File)
Sep 15 2024, 1:38 AM
Unknown Object (File)
Sep 15 2024, 1:38 AM
Unknown Object (File)
Sep 15 2024, 1:37 AM
Unknown Object (File)
Sep 15 2024, 1:37 AM
Unknown Object (File)
Sep 15 2024, 1:35 AM
Subscribers

Details

Summary

A version workflow would be useful, especially for less technical users. Additionally, whenever I am faced with a new command I reasonably expect $CMD [--help|help] and $CMD [--version|version] to work.

Test Plan

Ran arc version.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Add a `version` workflow to arcanist..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Show timestamp as well.

epriestley edited edge metadata.

See D9267, mostly.

Otherwise, if any of the paths are not git working copies or the git binary is not available on the system, we should recover gracefully. arc upgrade has a check for the former, although both workflows should probably check both.

This revision now requires changes to proceed.May 23 2014, 4:13 PM
joshuaspence edited edge metadata.
  • Simplify logic for determining the commit timestamp.
  • Fail gracefully if git is missing.
  • Fail gracefully if the .git directory does not exist.

This is what the output looks like:

> arc version
arcanist 635f49dc5466979d2ddef02269c512c2aff912c2 (24 May 2014)
libphutil 1add454ccdb7a23bd8d1823452c570bf2ae445e0 (19 May 2014)
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 24 2014, 2:35 AM
epriestley updated this revision to Diff 22028.

Closed by commit rARCb7bb6c834830 (authored by @joshuaspence, committed by @epriestley).