Fixes T4985, add manage page, change view page to show only panels. Arguably, PhabricatorDashboardArrangeController is no longer necessary. Also, still trying to figure out if I updated all flows that involve "arrange/{id}". Probably missed some. Also not sure of the Manage Dashboard icon. Please advise.
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4985: Make the default view of dashboards be just the dashboard
- Commits
- Restricted Diffusion Commit
rP6302414883ba: Make the default view of dashboards be just the dashboard
Create dashboard, add panels, "view/{id}" should show just panels, Manage Dashboard should show timeline and edit links.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dashboardmanagepage
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 653 Build 653: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Just copying some IRL chatter here for @chad, etc:
- We'll probably add "Install Dashboard" as a crumb link shortly unless someone has a better idea before that gets implemented.
- It would be theoretically nice if "Manage Dashboard" was, like, a dropdown with all the junk in it, maybe (?), but that's complicated and wouldn't work well on mobile right now.
- Or we could put some kind of very thin header on the page maybe?
- Basically, hiding all this stuff behind "Manage Dashboard" feels a tiny bit weird, but we don't have much of a place to put like 5 rarely-used links on the main page.
Comment Actions
If we have a dropdown built by ActionList, we should just be able to also pass it to Crumbs and get mobile for free.