Page MenuHomePhabricator

Make the default view of dashboards be just the dashboard
ClosedPublic

Authored by lpriestley on May 22 2014, 5:57 PM.
Tags
None
Referenced Files
F14060903: D9258.id21985.diff
Mon, Nov 18, 4:08 AM
F14060902: D9258.id21986.diff
Mon, Nov 18, 4:08 AM
F14036240: D9258.diff
Sun, Nov 10, 9:18 AM
F14035785: D9258.diff
Sun, Nov 10, 7:36 AM
F14008185: D9258.id21985.diff
Tue, Oct 29, 5:10 PM
F14004297: D9258.diff
Sat, Oct 26, 6:06 PM
F13977062: D9258.diff
Oct 18 2024, 4:55 PM
F13960817: D9258.id.diff
Oct 15 2024, 1:39 AM
Subscribers

Details

Summary

Fixes T4985, add manage page, change view page to show only panels. Arguably, PhabricatorDashboardArrangeController is no longer necessary. Also, still trying to figure out if I updated all flows that involve "arrange/{id}". Probably missed some. Also not sure of the Manage Dashboard icon. Please advise.

Test Plan

Create dashboard, add panels, "view/{id}" should show just panels, Manage Dashboard should show timeline and edit links.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lpriestley retitled this revision from to Make the default view of dashboards be just the dashboard.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
epriestley edited edge metadata.

Just copying some IRL chatter here for @chad, etc:

  • We'll probably add "Install Dashboard" as a crumb link shortly unless someone has a better idea before that gets implemented.
  • It would be theoretically nice if "Manage Dashboard" was, like, a dropdown with all the junk in it, maybe (?), but that's complicated and wouldn't work well on mobile right now.
  • Or we could put some kind of very thin header on the page maybe?
  • Basically, hiding all this stuff behind "Manage Dashboard" feels a tiny bit weird, but we don't have much of a place to put like 5 rarely-used links on the main page.
This revision is now accepted and ready to land.May 22 2014, 6:08 PM

If we have a dropdown built by ActionList, we should just be able to also pass it to Crumbs and get mobile for free.

epriestley updated this revision to Diff 21986.

Closed by commit rP6302414883ba (authored by @lpriestley, committed by @epriestley).