This isn't correct -- it closes as the configured default status, which might be anything (it's configurable with maniphest.status).

Er, maniphest.statuses.

Er, and as the closed status, not the default status (that's the default open status).

!close does this via email, too.

So its been a bit - is this button a "winner" ? IMHO - I wasn't a fan to begin with and I like it less now that its going to be huge.

I wasn't a fan to begin with, but have gotten used to it and think it's a slight net positive for me personally.

However, given T5083 and T5134 maybe we should just nuke it.

In an extreme case, we could do is add a button key to the existing config, and let you put a string in. Then states with a string would get a button, and other states would not -- so we could have it say "Close Task", users who find this too confusing can have it say "Close as 'Resolved'", and users who are completely overwhelmed by the button can remove it.

I like this slightly more than adding separate config, but not much more. I'm sort of inclined to just remove it.

I would remove the icon and fix the text. I don't think it's any bigger in that case and the action being 'more clear' provides some additional context. The main issue is we (at Phacility) are very anti-close task until it's fully resolved, where installs that have dedicated people just to manage bugs, would appreciate the less steps to close something.

IDK, I see both points. So either fix or remove...

If only we could slowvote this to 100 highly opinionated engineers.

Yeah, I think T5083 and T5134 are also both from relatively new installs, and I don't want to throw the baby out with the bathwater if this is mostly an onboarding problem.

You can get the status name like this:

$closed_status = ManiphestTaskStatus::getDefaultClosedStatus();
$closed_name = ManiphestTaskStatus::getTaskStatusName($closed_status);
$button_text = pht('Close as "%s"', $closed_name);

Maybe try that and we'll see how much better/worse things get?

If you want to keep it, I think you need to make it so that once you start typing in the box the text updates from

"Close as $status"

to

"Close as $status and comment"

...'cuz otherwise it would be confusing. :P

That said, I vote remove it please. I am actually pro aggressively closing tasks; I dislike the button because I am anti UI cruft. :D I generally like to remove as much as possible, though I am quite bad at doing that when I am building something new.

FWIW, I think this feature is intuitive if and only if you come from an extensive Github background, and is a crapshoot at best otherwise that really doesn't make sense within the rest of our UI. Worth noting as well the request to add this comes from a new install that was used to Github afaik - D8590#14 - and generally didn't feel all that strongly.

Taking a step back, I think we should either try to

• solve this more aggressively / directly
  • do we need to re-design this very general remarkup comment + action UI to accomodate some "quick actions"?
    • If we're in the business of saving seconds, I personally could use this for differential much, much more than Maniphest.
  • do we need to educate new users better who come from Github land? (D8590#14)
    • maybe some better placeholder text?
  • do some power users need to specify remarkup comment box action defaults? like "close" instead of comment?
  • do bug triage people need a "canned response and close" UI element?
    • truly doubtful anyone who uses this button often doesn't also have to cut and paste something...
  • do folks who need these really need to scroll to the bottom of the page rather than use an action in the header?
  • more ideas here?
• help users funnel 'these things come from the jungle and probably need to be closed' type things through nuance
  • obviously a long while out, so a stopgap for real problems is fine by me

Haha which part works? Remove it? (We do need to redesign this box at some point).

Haha which part works? Remove it?

Yeah, I'm removing it.

We do need to redesign this box at some point

Which box? The comment box thing as a whole?

Everything, everything always needs redesigned. But also mostly the "action" UX.

Do you have thoughts on how it should work instead? Maybe this is a reasonable time to explore them...

Or, I guess the issues I'm aware of are:

• It's a bit ugly.
• Selecting actions from the dropdown is kind of cumbersome sometimes.
• A few users find it particularly cumbersome, and have occasionally asked for one-click access to frequent actions (Accept, Close).
• (I don't personally really find it cumbersome at all.)
• A few users have difficulty figuring out how to take actions at all.

Preview-specific:

• Some users, especially new users, find the preview confusing (I think they often miss the "Preview" text).
• A few users don't like the preview.

And technical stuff:

• Action state doesn't save in all drafts.
• Preview should be disabled on mobile.

Ok, I can just toss that in a task and if I get any ideas, will update. I have no specific thoughts right now.