Page MenuHomePhabricator

"Close Task" button where "Cancel" button is expected
Closed, DuplicatePublic

Description

If you create a task, the buttons appear as expected: Cancel - Create Task.

At the end of the comments you get: Close Task - Submit

It is not uncommon to see new users (and not so new) resolving tasks accidentally because they click the "Close Task" button at the end of the comments. Usually what happens is that they are half way in a comment, think it twice and want to click "Cancel".

Arguably, "Close Task" is not an action that requires such a prominent shortcut right next to a very common action such as submitting a comment. Even from the possibilities for resolving, "Close Task" will pick only "Resolved", which makes the correct use case even less frequent. The dropdown menu already has an option to resolve tasks quickly.

Event Timeline

qgil raised the priority of this task from to Needs Triage.
qgil updated the task description. (Show Details)
qgil added a project: Maniphest.
qgil added a subscriber: qgil.

See some discussion in T4657 and D8590. This button was an explicit request from another install; this UI is familiar to GitHub users, as it mirrors a similar UI on GitHub:

Screen_Shot_2014-05-16_at_8.05.50_AM.png (288×791 px, 24 KB)

I'm very hesitant to introduce configuration for this. How big of an issue is it?

Usually what happens is that they are half way in a comment, think it twice and want to click "Cancel".

Possibly we could make the button change from "Close Task" to "Comment and Close Task" when you type text, but I'm not sure that would help much.

Nevermind, then. People will get used.

Note that GitHub doesn't have a "Cancel" button when creating an issue, therefore they don't have exactly the same risk of consufing users with the left button while creating issues or commenting on them. I will leave to you the question of how appropriate is to have a "Cancel" button when creating a task.

epriestley claimed this task.

Sounds good. I'm going to close this for now, but let us know if it's still a problem once people have had a little time to get used to it. (I wasn't too sure about it at first, but now that I'm more used to it I find it useful, and I don't think we've seen many accidental closes after the initial burst of "what does this button do", which gives me hope that people will get used to it pretty quickly.)

epriestley changed the task status from Wontfix to Duplicate.May 21 2014, 7:42 PM

✘ Merged into T4657.