Page MenuHomePhabricator

Add "Spaces", an application for managing policy namespaces

Authored by epriestley on May 19 2014, 9:55 PM.
Referenced Files
Unknown Object (File)
Mon, Nov 27, 6:43 AM
Unknown Object (File)
Sun, Nov 26, 1:41 AM
Unknown Object (File)
Thu, Nov 23, 11:58 AM
Unknown Object (File)
Tue, Nov 14, 9:15 AM
Unknown Object (File)
Sun, Nov 12, 1:25 PM
Unknown Object (File)
Nov 8 2023, 4:51 AM
Unknown Object (File)
Nov 8 2023, 4:51 AM
Unknown Object (File)
Nov 8 2023, 4:51 AM



Ref T3820. This doesn't actually do anything yet, but dumps in all the plumbing.

Test Plan

Screen_Shot_2014-05-19_at_2.53.49_PM.png (912×1 px, 101 KB)

Screen_Shot_2014-05-19_at_2.53.26_PM.png (912×1 px, 112 KB)

Screen_Shot_2014-05-19_at_2.53.34_PM.png (912×1 px, 121 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add "Spaces", an application for managing policy namespaces.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision is now accepted and ready to land.May 19 2014, 11:01 PM
epriestley edited edge metadata.

Modernize, mostly trivial changes:

  • Use modern $COLLATE patches.
  • Use handleRequest().
  • Remove device hint for pages.
  • Use buildTransactionTimeline().
  • Use validateIsEmptyTextField().
  • Fix a weird regex in PHIDType.
  • Use 1 and null more consistently as the available values for TYPE_DEFAULT.
  • Remove getCapabilityKey() from custom capabilities.
  • Add Application->getName().
  • Implement getApplicationClassName() and getResultTypeDescription() on SearchEngine.
  • Rename PHIDTypeNamespace to NamespacePHIDType.
  • Remove getTypeConstant() from PHIDType.
  • Add getEditorApplicationClass and getEditorObjectsDescription to Editor.
  • Implement PhabricatorApplicationTransactionInterface on Namespace.
  • Picked an icon.


  • Ran bin/storage upgrade -f, clean patches + no adjustments.
  • Created a new namespace (it became the default space).
  • Created another namespace (it became a non-default space).
  • Made a few edits.
  • Fiddled with default policies.
  • Tried to create a Space with "can create" set to "no one"; blocked with policy exception.
This revision was automatically updated to reflect the committed changes.