Ran arc lint --apply-patches --everything over rPHU, mainly to change double quotes to single quotes where appropriate. These changes also validate that the ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE rule is working as expected.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHU32f1dad1f4e5: Change double quotes to single quotes.
arc unit --everything and eyeballed the diff.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- lint-fixes
- Lint
Lint Errors Severity Location Code Message Error src/filesystem/Filesystem.php:403 XHP31 Use Of PHP 5.3 Features Error src/filesystem/Filesystem.php:559 XHP31 Use Of PHP 5.3 Features - Unit
Tests Passed - Build Status
Buildable 555 Build 555: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Closed by commit rPHU32f1dad1f4e5 (authored by @joshuaspence, committed by @epriestley).