Page MenuHomePhabricator

Change double quotes to single quotes.
ClosedPublic

Authored by joshuaspence on May 18 2014, 2:14 PM.
Tags
None
Referenced Files
F13286148: D9184.diff
Tue, Jun 4, 6:44 AM
F13285603: D9184.id21811.largetrue.diff
Mon, Jun 3, 11:43 PM
F13273017: D9184.diff
Fri, May 31, 1:28 AM
F13259388: D9184.id21811.diff
Sun, May 26, 8:01 PM
F13253257: D9184.id21811.diff
Sat, May 25, 2:32 AM
F13247050: D9184.diff
Thu, May 23, 3:20 PM
F13245920: D9184.id21811.largetrue.diff
Thu, May 23, 6:37 AM
F13235295: D9184.diff
Tue, May 21, 4:35 AM
Subscribers

Details

Summary

Ran arc lint --apply-patches --everything over rPHU, mainly to change double quotes to single quotes where appropriate. These changes also validate that the ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE rule is working as expected.

Test Plan

arc unit --everything and eyeballed the diff.

Diff Detail

Repository
rPHU libphutil
Branch
lint-fixes
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/filesystem/Filesystem.php:403XHP31Use Of PHP 5.3 Features
Errorsrc/filesystem/Filesystem.php:559XHP31Use Of PHP 5.3 Features
Unit
Tests Passed
Build Status
Buildable 555
Build 555: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Change double quotes to single quotes..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

These all look correct to me.

This revision is now accepted and ready to land.May 18 2014, 2:21 PM
epriestley updated this revision to Diff 21812.

Closed by commit rPHU32f1dad1f4e5 (authored by @joshuaspence, committed by @epriestley).