Page MenuHomePhabricator

Change double quotes to single quotes.
ClosedPublic

Authored by joshuaspence on May 18 2014, 2:14 PM.
Tags
None
Referenced Files
F13191053: D9184.largetrue.diff
Sat, May 11, 4:47 PM
F13184562: D9184.id21812.diff
Fri, May 10, 8:24 PM
F13177271: D9184.diff
Wed, May 8, 7:35 PM
Unknown Object (File)
Tue, May 7, 8:30 AM
Unknown Object (File)
Sat, May 4, 11:15 AM
Unknown Object (File)
Wed, May 1, 3:41 PM
Unknown Object (File)
Mon, Apr 29, 1:31 PM
Unknown Object (File)
Thu, Apr 25, 11:40 PM
Subscribers

Details

Summary

Ran arc lint --apply-patches --everything over rPHU, mainly to change double quotes to single quotes where appropriate. These changes also validate that the ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE rule is working as expected.

Test Plan

arc unit --everything and eyeballed the diff.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Change double quotes to single quotes..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

These all look correct to me.

This revision is now accepted and ready to land.May 18 2014, 2:21 PM
epriestley updated this revision to Diff 21812.

Closed by commit rPHU32f1dad1f4e5 (authored by @joshuaspence, committed by @epriestley).