Page MenuHomePhabricator
Differential D9179

Convert rest of SPRITE_STATUS to FontAwesome
ClosedPublic
Actions

Authored by chad on May 18 2014, 5:53 AM.
Tags
None
Referenced Files
F14092490: D9179.diff
Mon, Nov 25, 6:23 AM
Unknown Object (File)
Tue, Nov 19, 9:41 AM
Unknown Object (File)
Thu, Nov 14, 10:50 PM
Unknown Object (File)
Wed, Nov 13, 10:44 PM
Unknown Object (File)
Wed, Nov 13, 10:42 PM
Unknown Object (File)
Mon, Nov 11, 1:14 PM
Unknown Object (File)
Wed, Nov 6, 10:54 PM
Unknown Object (File)
Tue, Oct 29, 10:56 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4958: Replace Status Sprite with FontAwesome
T4739: Change typeaheads to use FontAwesome instead of old icons
Commits
Restricted Diffusion Commit
rP3a81f8c68d29: Convert rest of SPRITE_STATUS to FontAwesome
Summary

Updates policy, headers, typeaheads to FA over policy icons

Need advice - can't seem to place where icons come from on Typeahead? Wrong icons and wrong colors.... it is late

Test Plan
  • grepped for SPRITE_STATUS
  • grepped for sprite-status
  • grepped for setStatus for headers
  • grepped individual icons names

Browsed numerous places, checked new dropdowns, see pudgy people.

Diff Detail

Repository
rP Phabricator
Branch
status-icons
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 547
Build 547: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21800.May 18 2014, 5:53 AM
chad retitled this revision from to Convert rest of SPRITE_STATUS to FontAwesome.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 18 2014, 5:53 AM
Harbormaster completed remote builds in B547: Diff 21800.May 18 2014, 5:54 AM
epriestley accepted this revision.May 18 2014, 12:11 PM
epriestley edited edge metadata.

I think the inlines fix the typeahead. This should get cleaner after T4420.

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php
201

Make this fa-user bluegrey.

291

fa-briefcase bluegrey

This revision is now accepted and ready to land.May 18 2014, 12:11 PM
chad closed this revision.May 18 2014, 11:11 PM
chad updated this revision to Diff 21820.

Closed by commit rP3a81f8c68d29 (authored by @chad).

Large Diff

This large diff affects 249 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
resources/
celerity/
171 lines
1 line
sprite/
manifest/
status_1x/
status_2x/
scripts/
celerity/
1 line
src/
applications/
conpherence/
view/
10 lines
differential/
constants/
19 lines
diffusion/
controller/
6 lines
4 lines
harbormaster/
controller/
6 lines
query/
2 lines
herald/
controller/
8 lines
maniphest/
constants/
7 lines
meta/
controller/
4 lines
passphrase/
controller/
2 lines
query/
4 lines
people/
phid/
2 lines
policy/
storage/
21 lines
project/
controller/
2 lines
6 lines
4 lines
phid/
4 lines
2 lines
releeph/
controller/
branch/
4 lines
product/
4 lines
slowvote/
controller/
5 lines
typeahead/
controller/
4 lines
infrastructure/
celerity/
44 lines
view/
control/
4 lines
form/
control/
3 lines
phui/
8 lines
1 line
7 lines
webroot/
rsrc/
css/
aphront/
2 lines
phui/
2 lines
1 line
2 lines
image/
js/
application/
differential/
20 lines
policy/
2 lines
core/
2 lines
phuix/
10 lines

Diff 21800

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

resources/sprite/manifest/status.json

View Options

resources/sprite/status_1x/accept-blue.png

View Options

resources/sprite/status_1x/accept-dark.png

View Options

resources/sprite/status_1x/accept-green.png

View Options

resources/sprite/status_1x/accept-red.png

View Options

resources/sprite/status_1x/accept-white.png

View Options

resources/sprite/status_1x/accept.png

View Options

resources/sprite/status_1x/add-blue.png

View Options

resources/sprite/status_1x/add-dark.png

View Options

resources/sprite/status_1x/add-green.png

View Options

resources/sprite/status_1x/add-red.png

View Options

resources/sprite/status_1x/add-white.png

View Options

resources/sprite/status_1x/add.png

View Options

resources/sprite/status_1x/down-blue.png

View Options

resources/sprite/status_1x/down-dark.png

View Options

resources/sprite/status_1x/down-green.png

View Options

resources/sprite/status_1x/down-red.png

View Options

resources/sprite/status_1x/down-white.png

View Options

resources/sprite/status_1x/down.png

View Options

resources/sprite/status_1x/info-blue.png

View Options

resources/sprite/status_1x/info-dark.png

View Options

resources/sprite/status_1x/info-green.png

View Options

resources/sprite/status_1x/info-red.png

View Options

resources/sprite/status_1x/info-white.png

View Options

resources/sprite/status_1x/info.png

View Options

resources/sprite/status_1x/left-blue.png

View Options

resources/sprite/status_1x/left-dark.png

View Options

resources/sprite/status_1x/left-green.png

View Options

resources/sprite/status_1x/left-red.png

View Options

resources/sprite/status_1x/left-white.png

View Options

resources/sprite/status_1x/left.png

View Options

resources/sprite/status_1x/minus-blue.png

View Options

resources/sprite/status_1x/minus-dark.png

View Options

resources/sprite/status_1x/minus-green.png

View Options

resources/sprite/status_1x/minus-red.png

View Options

resources/sprite/status_1x/minus-white.png

View Options

resources/sprite/status_1x/minus.png

View Options

resources/sprite/status_1x/oh-closed-dark.png

View Options

resources/sprite/status_1x/oh-closed.png

View Options

resources/sprite/status_1x/oh-ok-dark.png

View Options

resources/sprite/status_1x/oh-ok.png

View Options

resources/sprite/status_1x/oh-open-green.png

View Options

resources/sprite/status_1x/oh-open-red.png

View Options

resources/sprite/status_1x/oh-open.png

View Options

resources/sprite/status_1x/open-blue.png

View Options

resources/sprite/status_1x/open-dark.png

View Options

resources/sprite/status_1x/open-green.png

View Options

resources/sprite/status_1x/open-red.png

View Options

resources/sprite/status_1x/open-white.png

View Options

resources/sprite/status_1x/open.png

View Options

resources/sprite/status_1x/pl-summary.png

View Options

resources/sprite/status_1x/pl-testplan.png

View Options

resources/sprite/status_1x/policy-admin-white.png

View Options

resources/sprite/status_1x/policy-admin.png

View Options

resources/sprite/status_1x/policy-all-white.png

View Options

resources/sprite/status_1x/policy-all.png

View Options

resources/sprite/status_1x/policy-custom-white.png

View Options

resources/sprite/status_1x/policy-custom.png

View Options

resources/sprite/status_1x/policy-elist-white.png

View Options

resources/sprite/status_1x/policy-elist.png

View Options

resources/sprite/status_1x/policy-noone-white.png

View Options

resources/sprite/status_1x/policy-noone.png

View Options

resources/sprite/status_1x/policy-project-white.png

View Options

resources/sprite/status_1x/policy-project.png

View Options

resources/sprite/status_1x/policy-public-white.png

View Options

resources/sprite/status_1x/policy-public.png

View Options

resources/sprite/status_1x/policy-unknown-white.png

View Options

resources/sprite/status_1x/policy-unknown.png

View Options

resources/sprite/status_1x/policy-user-white.png

View Options

resources/sprite/status_1x/policy-user.png

View Options

resources/sprite/status_1x/question-blue.png

View Options

resources/sprite/status_1x/question-dark.png

View Options

resources/sprite/status_1x/question-green.png

View Options

resources/sprite/status_1x/question-red.png

View Options

resources/sprite/status_1x/question-white.png

View Options

resources/sprite/status_1x/question.png

View Options

resources/sprite/status_1x/reject-blue.png

View Options

resources/sprite/status_1x/reject-dark.png

View Options

resources/sprite/status_1x/reject-green.png

View Options

resources/sprite/status_1x/reject-red.png

View Options

resources/sprite/status_1x/reject-white.png

View Options

resources/sprite/status_1x/reject.png

View Options

resources/sprite/status_1x/right-blue.png

View Options

resources/sprite/status_1x/right-dark.png

View Options

resources/sprite/status_1x/right-green.png

View Options

resources/sprite/status_1x/right-red.png

View Options

resources/sprite/status_1x/right-white.png

View Options

resources/sprite/status_1x/right.png

View Options

resources/sprite/status_1x/time-green.png

View Options

resources/sprite/status_1x/time-orange.png

View Options

resources/sprite/status_1x/time-red.png

View Options

resources/sprite/status_1x/time-yellow.png

View Options

resources/sprite/status_1x/up-blue.png

View Options

resources/sprite/status_1x/up-dark.png

View Options

resources/sprite/status_1x/up-green.png

View Options

resources/sprite/status_1x/up-red.png

View Options

resources/sprite/status_1x/up-white.png

View Options

resources/sprite/status_1x/up.png

View Options

resources/sprite/status_1x/warning-blue.png

View Options

resources/sprite/status_1x/warning-dark.png

View Options

resources/sprite/status_1x/warning-green.png

View Options

resources/sprite/status_1x/warning-red.png

View Options

resources/sprite/status_1x/warning-white.png

View Options

resources/sprite/status_1x/warning.png

View Options

resources/sprite/status_2x/accept-blue.png

View Options

resources/sprite/status_2x/accept-dark.png

View Options

resources/sprite/status_2x/accept-green.png

View Options

resources/sprite/status_2x/accept-red.png

View Options

resources/sprite/status_2x/accept-white.png

View Options

resources/sprite/status_2x/accept.png

View Options

resources/sprite/status_2x/add-blue.png

View Options

resources/sprite/status_2x/add-dark.png

View Options

resources/sprite/status_2x/add-green.png

View Options

resources/sprite/status_2x/add-red.png

View Options

resources/sprite/status_2x/add-white.png

View Options

resources/sprite/status_2x/add.png

View Options

resources/sprite/status_2x/down-blue.png

View Options

resources/sprite/status_2x/down-dark.png

View Options

resources/sprite/status_2x/down-green.png

View Options

resources/sprite/status_2x/down-red.png

View Options

resources/sprite/status_2x/down-white.png

View Options

resources/sprite/status_2x/down.png

View Options

resources/sprite/status_2x/info-blue.png

View Options

resources/sprite/status_2x/info-dark.png

View Options

resources/sprite/status_2x/info-green.png

View Options

resources/sprite/status_2x/info-red.png

View Options

resources/sprite/status_2x/info-white.png

View Options

resources/sprite/status_2x/info.png

View Options

resources/sprite/status_2x/left-blue.png

View Options

resources/sprite/status_2x/left-dark.png

View Options

resources/sprite/status_2x/left-green.png

View Options

resources/sprite/status_2x/left-red.png

View Options

resources/sprite/status_2x/left-white.png

View Options

resources/sprite/status_2x/left.png

View Options

resources/sprite/status_2x/minus-blue.png

View Options

resources/sprite/status_2x/minus-dark.png

View Options

resources/sprite/status_2x/minus-green.png

View Options

resources/sprite/status_2x/minus-red.png

View Options

resources/sprite/status_2x/minus-white.png

View Options

resources/sprite/status_2x/minus.png

View Options

resources/sprite/status_2x/oh-closed-dark.png

View Options

resources/sprite/status_2x/oh-closed.png

View Options

resources/sprite/status_2x/oh-ok-dark.png

View Options

resources/sprite/status_2x/oh-ok.png

View Options

resources/sprite/status_2x/oh-open-green.png

View Options

resources/sprite/status_2x/oh-open-red.png

View Options

resources/sprite/status_2x/oh-open.png

View Options

resources/sprite/status_2x/open-blue.png

View Options

resources/sprite/status_2x/open-dark.png

View Options

resources/sprite/status_2x/open-green.png

View Options

resources/sprite/status_2x/open-red.png

View Options

resources/sprite/status_2x/open-white.png

View Options

resources/sprite/status_2x/open.png

View Options

resources/sprite/status_2x/pl-summary.png

View Options

resources/sprite/status_2x/pl-testplan.png

View Options

resources/sprite/status_2x/policy-admin-white.png

View Options

resources/sprite/status_2x/policy-admin.png

View Options

resources/sprite/status_2x/policy-all-white.png

View Options

resources/sprite/status_2x/policy-all.png

View Options

resources/sprite/status_2x/policy-custom-white.png

View Options

resources/sprite/status_2x/policy-custom.png

View Options

resources/sprite/status_2x/policy-elist-white.png

View Options

resources/sprite/status_2x/policy-elist.png

View Options

resources/sprite/status_2x/policy-noone-white.png

View Options

resources/sprite/status_2x/policy-noone.png

View Options

resources/sprite/status_2x/policy-project-white.png

View Options

resources/sprite/status_2x/policy-project.png

View Options

resources/sprite/status_2x/policy-public-white.png

View Options

resources/sprite/status_2x/policy-public.png

View Options

resources/sprite/status_2x/policy-unknown-white.png

View Options

resources/sprite/status_2x/policy-unknown.png

View Options

resources/sprite/status_2x/policy-user-white.png

View Options

resources/sprite/status_2x/policy-user.png

View Options

resources/sprite/status_2x/question-blue.png

View Options

resources/sprite/status_2x/question-dark.png

View Options

resources/sprite/status_2x/question-green.png

View Options

resources/sprite/status_2x/question-red.png

View Options

resources/sprite/status_2x/question-white.png

View Options

resources/sprite/status_2x/question.png

View Options

resources/sprite/status_2x/reject-blue.png

View Options

resources/sprite/status_2x/reject-dark.png

View Options

resources/sprite/status_2x/reject-green.png

View Options

resources/sprite/status_2x/reject-red.png

View Options

resources/sprite/status_2x/reject-white.png

View Options

resources/sprite/status_2x/reject.png

View Options

resources/sprite/status_2x/right-blue.png

View Options

resources/sprite/status_2x/right-dark.png

View Options

resources/sprite/status_2x/right-green.png

View Options

resources/sprite/status_2x/right-red.png

View Options

resources/sprite/status_2x/right-white.png

View Options

resources/sprite/status_2x/right.png

View Options

resources/sprite/status_2x/time-green.png

View Options

resources/sprite/status_2x/time-orange.png

View Options

resources/sprite/status_2x/time-red.png

View Options

resources/sprite/status_2x/time-yellow.png

View Options

resources/sprite/status_2x/up-blue.png

View Options

resources/sprite/status_2x/up-dark.png

View Options

resources/sprite/status_2x/up-green.png

View Options

resources/sprite/status_2x/up-red.png

View Options

resources/sprite/status_2x/up-white.png

View Options

resources/sprite/status_2x/up.png

View Options

resources/sprite/status_2x/warning-blue.png

View Options

resources/sprite/status_2x/warning-dark.png

View Options

resources/sprite/status_2x/warning-green.png

View Options

resources/sprite/status_2x/warning-red.png

View Options

resources/sprite/status_2x/warning-white.png

View Options

resources/sprite/status_2x/warning.png

View Options

scripts/celerity/generate_sprites.php

View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

View Options

src/applications/differential/constants/DifferentialRevisionStatus.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

View Options

src/applications/herald/controller/HeraldRuleViewController.php

View Options

src/applications/maniphest/constants/ManiphestTaskStatus.php

View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

View Options

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

View Options

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php

View Options

src/applications/policy/storage/PhabricatorPolicy.php

View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

View Options

src/applications/project/controller/PhabricatorProjectEditMainController.php

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

View Options

src/applications/project/phid/PhabricatorProjectPHIDTypeColumn.php

View Options

src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php

View Options

src/applications/releeph/controller/branch/ReleephBranchViewController.php

View Options

src/applications/releeph/controller/product/ReleephProductViewController.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
View Options

src/infrastructure/celerity/CeleritySpriteGenerator.php

View Options

src/view/control/AphrontTokenizerTemplateView.php

View Options

src/view/form/control/AphrontFormPolicyControl.php

View Options

src/view/phui/PHUIHeaderView.php

View Options

src/view/phui/PHUIIconView.php

View Options

src/view/phui/PHUIPropertyListView.php

View Options

webroot/rsrc/css/aphront/typeahead.css

View Options

webroot/rsrc/css/phui/phui-header-view.css

View Options

webroot/rsrc/css/phui/phui-icon.css

View Options

webroot/rsrc/css/phui/phui-property-list-view.css

View Options

webroot/rsrc/css/sprite-status.css

View Options

webroot/rsrc/image/sprite-status-X2.png

View Options

webroot/rsrc/image/sprite-status.png

View Options

webroot/rsrc/js/application/differential/behavior-dropdown-menus.js

View Options

webroot/rsrc/js/application/policy/behavior-policy-control.js

View Options

webroot/rsrc/js/core/Prefab.js

View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Phabricator · Built by Phacility