Page MenuHomePhabricator
Differential D9179

Convert rest of SPRITE_STATUS to FontAwesome
ClosedPublic
Actions

Authored by chad on May 18 2014, 5:53 AM.
Tags
None
Referenced Files
F13259829: D9179.diff
Sun, May 26, 11:09 PM
F13244541: D9179.diff
Thu, May 23, 5:08 AM
F13235986: D9179.id21820.largetrue.diff
Tue, May 21, 7:26 AM
Unknown Object (File)
Tue, May 7, 5:31 AM
Unknown Object (File)
Mon, May 6, 11:47 PM
Unknown Object (File)
Mon, May 6, 11:37 AM
Unknown Object (File)
Fri, May 3, 3:25 AM
Unknown Object (File)
Mon, Apr 29, 2:42 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4958: Replace Status Sprite with FontAwesome
T4739: Change typeaheads to use FontAwesome instead of old icons
Commits
Restricted Diffusion Commit
rP3a81f8c68d29: Convert rest of SPRITE_STATUS to FontAwesome
Summary

Updates policy, headers, typeaheads to FA over policy icons

Need advice - can't seem to place where icons come from on Typeahead? Wrong icons and wrong colors.... it is late

Test Plan
  • grepped for SPRITE_STATUS
  • grepped for sprite-status
  • grepped for setStatus for headers
  • grepped individual icons names

Browsed numerous places, checked new dropdowns, see pudgy people.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 21800.May 18 2014, 5:53 AM
chad retitled this revision from to Convert rest of SPRITE_STATUS to FontAwesome.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 18 2014, 5:53 AM
Harbormaster completed remote builds in B547: Diff 21800.May 18 2014, 5:54 AM
epriestley accepted this revision.May 18 2014, 12:11 PM
epriestley edited edge metadata.

I think the inlines fix the typeahead. This should get cleaner after T4420.

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php
201

Make this fa-user bluegrey.

291

fa-briefcase bluegrey

This revision is now accepted and ready to land.May 18 2014, 12:11 PM
chad closed this revision.May 18 2014, 11:11 PM
chad updated this revision to Diff 21820.

Closed by commit rP3a81f8c68d29 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
175 lines
1 line
sprite/
manifest/
status_1x/
status_2x/
scripts/
celerity/
1 line
src/
applications/
conpherence/
view/
10 lines
differential/
constants/
19 lines
diffusion/
controller/
6 lines
4 lines
harbormaster/
controller/
6 lines
query/
2 lines
herald/
controller/
8 lines
maniphest/
constants/
7 lines
meta/
controller/
4 lines
passphrase/
controller/
2 lines
query/
4 lines
people/
phid/
2 lines
policy/
storage/
21 lines
project/
controller/
2 lines
6 lines
4 lines
phid/
4 lines
2 lines
releeph/
controller/
branch/
4 lines
product/
4 lines
slowvote/
controller/
5 lines
typeahead/
controller/
4 lines
infrastructure/
celerity/
44 lines
view/
control/
4 lines
form/
control/
3 lines
phui/
8 lines
1 line
7 lines
webroot/
rsrc/
css/
aphront/
12 lines
phui/
2 lines
1 line
2 lines
image/
js/
application/
differential/
20 lines
policy/
2 lines
core/
2 lines
phuix/
10 lines

Diff 21820

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

resources/sprite/manifest/status.json

Loading...
View Options

resources/sprite/status_1x/accept-blue.png

Loading...
View Options

resources/sprite/status_1x/accept-dark.png

Loading...
View Options

resources/sprite/status_1x/accept-green.png

Loading...
View Options

resources/sprite/status_1x/accept-red.png

Loading...
View Options

resources/sprite/status_1x/accept-white.png

Loading...
View Options

resources/sprite/status_1x/accept.png

Loading...
View Options

resources/sprite/status_1x/add-blue.png

Loading...
View Options

resources/sprite/status_1x/add-dark.png

Loading...
View Options

resources/sprite/status_1x/add-green.png

Loading...
View Options

resources/sprite/status_1x/add-red.png

Loading...
View Options

resources/sprite/status_1x/add-white.png

Loading...
View Options

resources/sprite/status_1x/add.png

Loading...
View Options

resources/sprite/status_1x/down-blue.png

Loading...
View Options

resources/sprite/status_1x/down-dark.png

Loading...
View Options

resources/sprite/status_1x/down-green.png

Loading...
View Options

resources/sprite/status_1x/down-red.png

Loading...
View Options

resources/sprite/status_1x/down-white.png

Loading...
View Options

resources/sprite/status_1x/down.png

Loading...
View Options

resources/sprite/status_1x/info-blue.png

Loading...
View Options

resources/sprite/status_1x/info-dark.png

Loading...
View Options

resources/sprite/status_1x/info-green.png

Loading...
View Options

resources/sprite/status_1x/info-red.png

Loading...
View Options

resources/sprite/status_1x/info-white.png

Loading...
View Options

resources/sprite/status_1x/info.png

Loading...
View Options

resources/sprite/status_1x/left-blue.png

Loading...
View Options

resources/sprite/status_1x/left-dark.png

Loading...
View Options

resources/sprite/status_1x/left-green.png

Loading...
View Options

resources/sprite/status_1x/left-red.png

Loading...
View Options

resources/sprite/status_1x/left-white.png

Loading...
View Options

resources/sprite/status_1x/left.png

Loading...
View Options

resources/sprite/status_1x/minus-blue.png

Loading...
View Options

resources/sprite/status_1x/minus-dark.png

Loading...
View Options

resources/sprite/status_1x/minus-green.png

Loading...
View Options

resources/sprite/status_1x/minus-red.png

Loading...
View Options

resources/sprite/status_1x/minus-white.png

Loading...
View Options

resources/sprite/status_1x/minus.png

Loading...
View Options

resources/sprite/status_1x/oh-closed-dark.png

Loading...
View Options

resources/sprite/status_1x/oh-closed.png

Loading...
View Options

resources/sprite/status_1x/oh-ok-dark.png

Loading...
View Options

resources/sprite/status_1x/oh-ok.png

Loading...
View Options

resources/sprite/status_1x/oh-open-green.png

Loading...
View Options

resources/sprite/status_1x/oh-open-red.png

Loading...
View Options

resources/sprite/status_1x/oh-open.png

Loading...
View Options

resources/sprite/status_1x/open-blue.png

Loading...
View Options

resources/sprite/status_1x/open-dark.png

Loading...
View Options

resources/sprite/status_1x/open-green.png

Loading...
View Options

resources/sprite/status_1x/open-red.png

Loading...
View Options

resources/sprite/status_1x/open-white.png

Loading...
View Options

resources/sprite/status_1x/open.png

Loading...
View Options

resources/sprite/status_1x/pl-summary.png

Loading...
View Options

resources/sprite/status_1x/pl-testplan.png

Loading...
View Options

resources/sprite/status_1x/policy-admin-white.png

Loading...
View Options

resources/sprite/status_1x/policy-admin.png

Loading...
View Options

resources/sprite/status_1x/policy-all-white.png

Loading...
View Options

resources/sprite/status_1x/policy-all.png

Loading...
View Options

resources/sprite/status_1x/policy-custom-white.png

Loading...
View Options

resources/sprite/status_1x/policy-custom.png

Loading...
View Options

resources/sprite/status_1x/policy-elist-white.png

Loading...
View Options

resources/sprite/status_1x/policy-elist.png

Loading...
View Options

resources/sprite/status_1x/policy-noone-white.png

Loading...
View Options

resources/sprite/status_1x/policy-noone.png

Loading...
View Options

resources/sprite/status_1x/policy-project-white.png

Loading...
View Options

resources/sprite/status_1x/policy-project.png

Loading...
View Options

resources/sprite/status_1x/policy-public-white.png

Loading...
View Options

resources/sprite/status_1x/policy-public.png

Loading...
View Options

resources/sprite/status_1x/policy-unknown-white.png

Loading...
View Options

resources/sprite/status_1x/policy-unknown.png

Loading...
View Options

resources/sprite/status_1x/policy-user-white.png

Loading...
View Options

resources/sprite/status_1x/policy-user.png

Loading...
View Options

resources/sprite/status_1x/question-blue.png

Loading...
View Options

resources/sprite/status_1x/question-dark.png

Loading...
View Options

resources/sprite/status_1x/question-green.png

Loading...
View Options

resources/sprite/status_1x/question-red.png

Loading...
View Options

resources/sprite/status_1x/question-white.png

Loading...
View Options

resources/sprite/status_1x/question.png

Loading...
View Options

resources/sprite/status_1x/reject-blue.png

Loading...
View Options

resources/sprite/status_1x/reject-dark.png

Loading...
View Options

resources/sprite/status_1x/reject-green.png

Loading...
View Options

resources/sprite/status_1x/reject-red.png

Loading...
View Options

resources/sprite/status_1x/reject-white.png

Loading...
View Options

resources/sprite/status_1x/reject.png

Loading...
View Options

resources/sprite/status_1x/right-blue.png

Loading...
View Options

resources/sprite/status_1x/right-dark.png

Loading...
View Options

resources/sprite/status_1x/right-green.png

Loading...
View Options

resources/sprite/status_1x/right-red.png

Loading...
View Options

resources/sprite/status_1x/right-white.png

Loading...
View Options

resources/sprite/status_1x/right.png

Loading...
View Options

resources/sprite/status_1x/time-green.png

Loading...
View Options

resources/sprite/status_1x/time-orange.png

Loading...
View Options

resources/sprite/status_1x/time-red.png

Loading...
View Options

resources/sprite/status_1x/time-yellow.png

Loading...
View Options

resources/sprite/status_1x/up-blue.png

Loading...
View Options

resources/sprite/status_1x/up-dark.png

Loading...
View Options

resources/sprite/status_1x/up-green.png

Loading...
View Options

resources/sprite/status_1x/up-red.png

Loading...
View Options

resources/sprite/status_1x/up-white.png

Loading...
View Options

resources/sprite/status_1x/up.png

Loading...
View Options

resources/sprite/status_1x/warning-blue.png

Loading...
View Options

resources/sprite/status_1x/warning-dark.png

Loading...
View Options

resources/sprite/status_1x/warning-green.png

Loading...
View Options

resources/sprite/status_1x/warning-red.png

Loading...
View Options

resources/sprite/status_1x/warning-white.png

Loading...
View Options

resources/sprite/status_1x/warning.png

Loading...
View Options

resources/sprite/status_2x/accept-blue.png

Loading...
View Options

resources/sprite/status_2x/accept-dark.png

Loading...
View Options

resources/sprite/status_2x/accept-green.png

Loading...
View Options

resources/sprite/status_2x/accept-red.png

Loading...
View Options

resources/sprite/status_2x/accept-white.png

Loading...
View Options

resources/sprite/status_2x/accept.png

Loading...
View Options

resources/sprite/status_2x/add-blue.png

Loading...
View Options

resources/sprite/status_2x/add-dark.png

Loading...
View Options

resources/sprite/status_2x/add-green.png

Loading...
View Options

resources/sprite/status_2x/add-red.png

Loading...
View Options

resources/sprite/status_2x/add-white.png

Loading...
View Options

resources/sprite/status_2x/add.png

Loading...
View Options

resources/sprite/status_2x/down-blue.png

Loading...
View Options

resources/sprite/status_2x/down-dark.png

Loading...
View Options

resources/sprite/status_2x/down-green.png

Loading...
View Options

resources/sprite/status_2x/down-red.png

Loading...
View Options

resources/sprite/status_2x/down-white.png

Loading...
View Options

resources/sprite/status_2x/down.png

Loading...
View Options

resources/sprite/status_2x/info-blue.png

Loading...
View Options

resources/sprite/status_2x/info-dark.png

Loading...
View Options

resources/sprite/status_2x/info-green.png

Loading...
View Options

resources/sprite/status_2x/info-red.png

Loading...
View Options

resources/sprite/status_2x/info-white.png

Loading...
View Options

resources/sprite/status_2x/info.png

Loading...
View Options

resources/sprite/status_2x/left-blue.png

Loading...
View Options

resources/sprite/status_2x/left-dark.png

Loading...
View Options

resources/sprite/status_2x/left-green.png

Loading...
View Options

resources/sprite/status_2x/left-red.png

Loading...
View Options

resources/sprite/status_2x/left-white.png

Loading...
View Options

resources/sprite/status_2x/left.png

Loading...
View Options

resources/sprite/status_2x/minus-blue.png

Loading...
View Options

resources/sprite/status_2x/minus-dark.png

Loading...
View Options

resources/sprite/status_2x/minus-green.png

Loading...
View Options

resources/sprite/status_2x/minus-red.png

Loading...
View Options

resources/sprite/status_2x/minus-white.png

Loading...
View Options

resources/sprite/status_2x/minus.png

Loading...
View Options

resources/sprite/status_2x/oh-closed-dark.png

Loading...
View Options

resources/sprite/status_2x/oh-closed.png

Loading...
View Options

resources/sprite/status_2x/oh-ok-dark.png

Loading...
View Options

resources/sprite/status_2x/oh-ok.png

Loading...
View Options

resources/sprite/status_2x/oh-open-green.png

Loading...
View Options

resources/sprite/status_2x/oh-open-red.png

Loading...
View Options

resources/sprite/status_2x/oh-open.png

Loading...
View Options

resources/sprite/status_2x/open-blue.png

Loading...
View Options

resources/sprite/status_2x/open-dark.png

Loading...
View Options

resources/sprite/status_2x/open-green.png

Loading...
View Options

resources/sprite/status_2x/open-red.png

Loading...
View Options

resources/sprite/status_2x/open-white.png

Loading...
View Options

resources/sprite/status_2x/open.png

Loading...
View Options

resources/sprite/status_2x/pl-summary.png

Loading...
View Options

resources/sprite/status_2x/pl-testplan.png

Loading...
View Options

resources/sprite/status_2x/policy-admin-white.png

Loading...
View Options

resources/sprite/status_2x/policy-admin.png

Loading...
View Options

resources/sprite/status_2x/policy-all-white.png

Loading...
View Options

resources/sprite/status_2x/policy-all.png

Loading...
View Options

resources/sprite/status_2x/policy-custom-white.png

Loading...
View Options

resources/sprite/status_2x/policy-custom.png

Loading...
View Options

resources/sprite/status_2x/policy-elist-white.png

Loading...
View Options

resources/sprite/status_2x/policy-elist.png

Loading...
View Options

resources/sprite/status_2x/policy-noone-white.png

Loading...
View Options

resources/sprite/status_2x/policy-noone.png

Loading...
View Options

resources/sprite/status_2x/policy-project-white.png

Loading...
View Options

resources/sprite/status_2x/policy-project.png

Loading...
View Options

resources/sprite/status_2x/policy-public-white.png

Loading...
View Options

resources/sprite/status_2x/policy-public.png

Loading...
View Options

resources/sprite/status_2x/policy-unknown-white.png

Loading...
View Options

resources/sprite/status_2x/policy-unknown.png

Loading...
View Options

resources/sprite/status_2x/policy-user-white.png

Loading...
View Options

resources/sprite/status_2x/policy-user.png

Loading...
View Options

resources/sprite/status_2x/question-blue.png

Loading...
View Options

resources/sprite/status_2x/question-dark.png

Loading...
View Options

resources/sprite/status_2x/question-green.png

Loading...
View Options

resources/sprite/status_2x/question-red.png

Loading...
View Options

resources/sprite/status_2x/question-white.png

Loading...
View Options

resources/sprite/status_2x/question.png

Loading...
View Options

resources/sprite/status_2x/reject-blue.png

Loading...
View Options

resources/sprite/status_2x/reject-dark.png

Loading...
View Options

resources/sprite/status_2x/reject-green.png

Loading...
View Options

resources/sprite/status_2x/reject-red.png

Loading...
View Options

resources/sprite/status_2x/reject-white.png

Loading...
View Options

resources/sprite/status_2x/reject.png

Loading...
View Options

resources/sprite/status_2x/right-blue.png

Loading...
View Options

resources/sprite/status_2x/right-dark.png

Loading...
View Options

resources/sprite/status_2x/right-green.png

Loading...
View Options

resources/sprite/status_2x/right-red.png

Loading...
View Options

resources/sprite/status_2x/right-white.png

Loading...
View Options

resources/sprite/status_2x/right.png

Loading...
View Options

resources/sprite/status_2x/time-green.png

Loading...
View Options

resources/sprite/status_2x/time-orange.png

Loading...
View Options

resources/sprite/status_2x/time-red.png

Loading...
View Options

resources/sprite/status_2x/time-yellow.png

Loading...
View Options

resources/sprite/status_2x/up-blue.png

Loading...
View Options

resources/sprite/status_2x/up-dark.png

Loading...
View Options

resources/sprite/status_2x/up-green.png

Loading...
View Options

resources/sprite/status_2x/up-red.png

Loading...
View Options

resources/sprite/status_2x/up-white.png

Loading...
View Options

resources/sprite/status_2x/up.png

Loading...
View Options

resources/sprite/status_2x/warning-blue.png

Loading...
View Options

resources/sprite/status_2x/warning-dark.png

Loading...
View Options

resources/sprite/status_2x/warning-green.png

Loading...
View Options

resources/sprite/status_2x/warning-red.png

Loading...
View Options

resources/sprite/status_2x/warning-white.png

Loading...
View Options

resources/sprite/status_2x/warning.png

Loading...
View Options

scripts/celerity/generate_sprites.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

Loading...
View Options

src/applications/differential/constants/DifferentialRevisionStatus.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/maniphest/constants/ManiphestTaskStatus.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
View Options

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

Loading...
View Options

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php

Loading...
View Options

src/applications/policy/storage/PhabricatorPolicy.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditMainController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/phid/PhabricatorProjectPHIDTypeColumn.php

Loading...
View Options

src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchViewController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductViewController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
View Options

src/infrastructure/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/view/control/AphrontTokenizerTemplateView.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

src/view/phui/PHUIIconView.php

Loading...
View Options

src/view/phui/PHUIPropertyListView.php

Loading...
View Options

webroot/rsrc/css/aphront/typeahead.css

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
View Options

webroot/rsrc/css/sprite-status.css

Loading...
View Options

webroot/rsrc/image/sprite-status-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-status.png

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-dropdown-menus.js

Loading...
View Options

webroot/rsrc/js/application/policy/behavior-policy-control.js

Loading...
View Options

webroot/rsrc/js/core/Prefab.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...
Phabricator · Built by Phacility