Fix the `ArcanistJSHintLinter::getVersion` function.
ClosedPublic
Actions

Authored by joshuaspence on May 18 2014, 1:08 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4954: Allow version dependencies to be specified for external linters

Commits

rARC7c56fad48fc7: Fix the `ArcanistJSHintLinter::getVersion` function.

Summary

As identified by @epriestley in D9060, jshint --version emits version information on stderr, not stdout.

Test Plan

Ran jshint --version locally and verified that the version information is output to stderr.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21788.May 18 2014, 1:08 AM

joshuaspence retitled this revision from to Fix the `ArcanistJSHintLinter::getVersion` function..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a subscriber: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2014, 1:08 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Harbormaster completed remote builds in B539: Diff 21788.May 18 2014, 1:09 AM

joshuaspence added a task: T4954: Allow version dependencies to be specified for external linters.May 18 2014, 1:09 AM

epriestley accepted this revision.May 18 2014, 1:17 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 18 2014, 1:17 AM

Closed by commit rARC7c56fad48fc7 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistJSHintLinter.php

7 lines

Diff 21790

View Options

src/lint/linter/ArcanistJSHintLinter.php

Fix the `ArcanistJSHintLinter::getVersion` function.ClosedPublicActions