Page MenuHomePhabricator

Improve 'arc get-config', 'arc set-config' and show more config info with --trace
ClosedPublic

Authored by epriestley on May 18 2014, 12:57 AM.
Tags
None
Referenced Files
F15507832: D9172.id21787.diff
Tue, Apr 15, 11:21 PM
F15505830: D9172.id.diff
Tue, Apr 15, 6:13 AM
F15505470: D9172.id21895.diff
Tue, Apr 15, 3:15 AM
F15503519: D9172.diff
Mon, Apr 14, 10:26 AM
F15475408: D9172.id21895.diff
Sun, Apr 6, 7:41 PM
F15459276: D9172.id.diff
Mon, Mar 31, 11:35 AM
F15410873: D9172.diff
Mar 19 2025, 8:37 AM
F15403969: D9172.diff
Mar 18 2025, 5:43 AM
Subscribers

Details

Summary

Fixes T4952. Several issues:

  • You review configuration values with arc set-config --show. This makes no sense and never has, I think it just predated arc get-config or was easier or something.
    • Instead, review values with arc get-config and review details with arc get-config --verbose.
  • Show better and more detailed information about all config sources.
  • Establish and show default values from a new "default" source.
  • With --trace include more information about attempts to read configuration files.
Test Plan

Ran arc get-config --trace --verbose in various working directories and received sensible-looking output.

Screen_Shot_2014-05-17_at_5.49.45_PM.png (310×590 px, 33 KB)

Diff Detail

Repository
rARC Arcanist
Branch
gsconfig
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 538
Build 538: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve 'arc get-config', 'arc set-config' and show more config info with --trace.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:20 PM
epriestley updated this revision to Diff 21895.

Closed by commit rARC104219dd62ee (authored by @epriestley).