Allow public countdowns to be viewed by logged out users
ClosedPublic
Actions

Authored by epriestley on May 17 2014, 7:41 PM.

Details

Reviewers

Maniphest Tasks

T4830: Applications with Public permissions requiring users to login
T5093: "Public" view policy does not work for Countdown

Commits

Restricted Diffusion Commit
rP1efb7e9497f3: Allow public countdowns to be viewed by logged out users

Summary

Fixes T5093. Ref T4830.

Test Plan

As a logged out user, viewed a public countdown detail page.
(Tried to view a nonpublic one, got asked to login.)

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21770.May 17 2014, 7:41 PM

epriestley retitled this revision from to Allow public countdowns to be viewed by logged out users.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T5093: "Public" view policy does not work for Countdown, T4830: Applications with Public permissions requiring users to login.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 17 2014, 7:41 PM

Harbormaster completed remote builds in B527: Diff 21770.May 17 2014, 7:42 PM

btrahan accepted this revision.May 17 2014, 8:05 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 17 2014, 8:05 PM

Closed by commit rP1efb7e9497f3 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

countdown/

controller/

PhabricatorCountdownViewController.php

8 lines

Diff 21777

View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Allow public countdowns to be viewed by logged out usersClosedPublicActions