Page MenuHomePhabricator
Differential D9160

Fix the `ArcanistJSONLintLinter::getVersion` function.
ClosedPublic
Actions

Authored by joshuaspence on May 17 2014, 11:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:18 AM
Unknown Object (File)
Sun, Dec 1, 11:26 PM
Unknown Object (File)
Sat, Nov 30, 3:14 PM
Unknown Object (File)
Sun, Nov 24, 10:54 PM
Unknown Object (File)
Nov 21 2024, 2:32 AM
Unknown Object (File)
Nov 17 2024, 12:18 AM
Unknown Object (File)
Nov 16 2024, 10:28 PM
Unknown Object (File)
Oct 22 2024, 8:18 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4954: Allow version dependencies to be specified for external linters
Commits
rARC4181fbde12a7: Fix the `ArcanistJSONLintLinter::getVersion` function.
Summary

Ref T4954. There was a typo in the original implementation. It wasn't noticed until now because the getVersion function isn't really used anywhere.

Test Plan

Ran arc linters in a repository with ArcanistJSONLintLinter configured, noticed that the version number appeared in the output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21768.May 17 2014, 11:51 AM
joshuaspence retitled this revision from to Fix the `ArcanistJSONLintLinter::getVersion` function..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2014, 11:51 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence updated this object.May 17 2014, 11:52 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T4954: Allow version dependencies to be specified for external linters.
Harbormaster completed remote builds in B525: Diff 21768.May 17 2014, 11:52 AM
epriestley accepted this revision.May 18 2014, 1:36 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2014, 1:36 AM
epriestley closed this revision.May 18 2014, 1:36 AM
epriestley updated this revision to Diff 21792.

Closed by commit rARC4181fbde12a7 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
2 lines

Diff 21792

View Options

src/lint/linter/ArcanistJSONLintLinter.php

Loading...
Phabricator · Built by Phacility