Differential D9137

Move people list rendering into SearchEngine
ClosedPublic
Actions

Authored by epriestley on May 15 2014, 5:14 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4986: Implement new Dashboard panel types

Commits

Restricted Diffusion Commit
rP5b3ccfd95fb9: Move people list rendering into SearchEngine

Summary

Ref T4986. One note:

We have a separate "browse directory" capability, to provide some soft privacy for users of public installs. Respect that policy within the SearchEngine.
Also restore some other icons I missed earlier.

Test Plan

Viewed people list.
Build people panel.
Verified people panel was just me without browse capability.

Diff Detail

Repository

rP Phabricator

Branch

dash2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 488
Build 488: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21705.May 15 2014, 5:14 PM

epriestley retitled this revision from to Move people list rendering into SearchEngine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4986: Implement new Dashboard panel types.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2014, 5:14 PM

Harbormaster completed remote builds in B488: Diff 21705.May 15 2014, 5:15 PM

btrahan accepted this revision.May 15 2014, 7:44 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 15 2014, 7:44 PM

Closed by commit rP5b3ccfd95fb9 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleListController.php

79 lines

query/

PhabricatorPeopleSearchEngine.php

93 lines

Diff 21705

View Options

src/applications/people/controller/PhabricatorPeopleListController.php