Paths

Table of Contentst

Add an `selectDescendantsOfTypes` to the `AASTNode`.
ClosedPublic
Actions

Authored by joshuaspence on May 15 2014, 1:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 31, 6:57 PM

	Unknown Object (File)
	Mon, Dec 30, 3:00 AM

	Unknown Object (File)
	Sun, Dec 29, 3:54 AM

	Unknown Object (File)
	Thu, Dec 26, 7:41 PM

	Unknown Object (File)
	Mon, Dec 23, 9:50 AM

	Unknown Object (File)
	Mon, Dec 23, 9:50 AM

	Unknown Object (File)
	Mon, Dec 23, 9:50 AM

	Unknown Object (File)
	Sun, Dec 22, 5:19 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU9399881fd82a: Add an `selectDescendantsOfTypes` to the `AASTNode`.

Summary

This method generally seems to make sense (there already exists such a method in the AASTNodeList class). Additionally, such a method simplifies D9117 slightly.

Test Plan

Ran the unit tests in rARC, which generally rely on this class.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21696.May 15 2014, 1:53 PM

joshuaspence retitled this revision from to Add an `selectDescendantsOfTypes` to the `AASTNode`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2014, 1:53 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.May 15 2014, 1:54 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 15 2014, 1:54 PM

Harbormaster completed remote builds in B483: Diff 21696.May 15 2014, 1:54 PM

Closed by commit rPHU9399881fd82a (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

aast/

api/

AASTNode.php

19 lines

Diff 21697

View Options

src/parser/aast/api/AASTNode.php

Add an `selectDescendantsOfTypes` to the `AASTNode`.ClosedPublicActions