Pass correct number of parameters to pht() when closing a branch in Mercurial
ClosedPublic
Actions

Authored by epriestley on May 14 2014, 3:49 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5050: Cannot Push Branch Close Commits to Hosted Mercurial Repositories

Commits

Restricted Diffusion Commit
rPfe0c98faccbc: Pass correct number of parameters to pht() when closing a branch in Mercurial

Summary

Ref T5050. This fixes the immediate error (bad pht()) but doesn't fix the other error (can't --close-branch) yet.

Test Plan

Pushed a --close-branch commit, got a first-level error instead of an error about an error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21661.May 14 2014, 3:49 PM

epriestley retitled this revision from to Pass correct number of parameters to pht() when closing a branch in Mercurial.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5050: Cannot Push Branch Close Commits to Hosted Mercurial Repositories.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 14 2014, 3:49 PM

Harbormaster completed remote builds in B460: Diff 21661.May 14 2014, 3:50 PM

btrahan accepted this revision.May 14 2014, 4:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 14 2014, 4:40 PM

Closed by commit rPfe0c98faccbc (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

8 lines

Diff 21679

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Pass correct number of parameters to pht() when closing a branch in MercurialClosedPublicActions