Page MenuHomePhabricator
Differential D9096

Minor cleanup of linter testing code.
ClosedPublic
Actions

Authored by joshuaspence on May 13 2014, 1:10 PM.
Tags
None
Referenced Files
F13814758: D9096.id21608.diff
Thu, Sep 19, 6:54 AM
F13814757: D9096.id21607.diff
Thu, Sep 19, 6:54 AM
F13814756: D9096.diff
Thu, Sep 19, 6:54 AM
Unknown Object (File)
Sun, Sep 15, 1:56 AM
Unknown Object (File)
Sun, Sep 15, 1:55 AM
Unknown Object (File)
Sun, Sep 15, 1:55 AM
Unknown Object (File)
Sun, Sep 15, 1:55 AM
Unknown Object (File)
Fri, Sep 6, 9:18 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCd826bf65c620: Minor cleanup of linter testing code.
Summary

Just some minor cleaning up, including:

  • Removing old annotations for Diviner.
  • Renaming some lint-test files so that the directory name bears a closer resemblance to that of the linter.
  • Remove some useless return statements.
Test Plan

arc unit.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21607.May 13 2014, 1:10 PM
joshuaspence retitled this revision from to Minor cleanup of linter testing code..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2014, 1:10 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B428: Diff 21607.May 13 2014, 1:11 PM
epriestley accepted this revision.May 13 2014, 1:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 13 2014, 1:15 PM
epriestley closed this revision.May 13 2014, 1:16 PM
epriestley updated this revision to Diff 21608.

Closed by commit rARCd826bf65c620 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Diff 21608

View Options

src/lint/linter/__tests__/ArcanistArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistFlake8LinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistNoLintTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPHPCSLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPuppetLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPyFlakesLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistRubyLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistSpellingLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistTextLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/cpp/googlestyle.lint-test

Loading...
View Options

src/lint/linter/__tests__/cpplint/googlestyle.lint-test

Loading...
Phabricator · Built by Phacility