Add a SublimeText-style repository typeahead
ClosedPublic
Actions

Authored by epriestley on May 13 2014, 3:10 AM.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP436f0563e81f: Add a SublimeText-style repository typeahead

Summary

Allows you to quickly search for files within a repository. Roughly:

We build a big tree of everything and ship it to the client.
The client implements a bunch of Sublime-ish magic to find paths.

Test Plan

Screen_Shot_2014-05-12_at_7.42.54_PM.png (1×1 px, 295 KB)

Diff Detail

Repository

rP Phabricator

Branch

browse2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 415
Build 415: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21592.May 13 2014, 3:10 AM

epriestley retitled this revision from to Add a SublimeText-style repository typeahead.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a subscriber: zeeg.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 13 2014, 3:10 AM

Harbormaster completed remote builds in B415: Diff 21592.May 13 2014, 3:11 AM

Very nkce

awesometown

webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js
119–125	is purging the cache necessary? i'd hope in practice this isn't necessary, and otherwise i'd guess we're need an LRU-style cache with a memory limit or something to keep performance in line.

This revision is now accepted and ready to land.May 13 2014, 9:03 PM

This will probably need some tweaks (and if your repository has like 100K files in it I'm not sure how usable it will be) but we can see what issues we hit. For Phabricator-sized repos it feels pretty good to me.

webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js
119–125	It shouldn't be necessary, but in theory a user can leave the page open for a day and type "a", "aa", "ab", etc., and potentially use a lot of memory. During normal use this shouldn't matter but I trust users to be inventive when it comes to this kind of thing.