Use `k in map`, not `array.indexOf`, in Event.js
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 9:28 PM.

Tags

None

Referenced Files

	F13246037: D9082.diff
	Thu, May 23, 7:15 AM

	F13192724: D9082.diff
	Sun, May 12, 9:29 AM

	Unknown Object (File)
	Sat, Apr 27, 12:49 AM

	Unknown Object (File)
	Fri, Apr 26, 3:36 PM

	Unknown Object (File)
	Apr 21 2024, 7:39 PM

	Unknown Object (File)
	Apr 9 2024, 8:35 PM

	Unknown Object (File)
	Apr 5 2024, 11:54 PM

	Unknown Object (File)
	Apr 5 2024, 4:16 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T5023: Unable to drag/reorder tasks in any version of IE

Commits

Restricted Diffusion Commit
rP91eb751d6f3d: Use `k in map`, not `array.indexOf`, in Event.js

Summary

See T5023.

Test Plan

Dragged stuff.

Diff Detail

Repository

rP Phabricator

Branch

indexof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 409
Build 409: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21584.May 12 2014, 9:28 PM

epriestley retitled this revision from to Use `k in map`, not `array.indexOf`, in Event.js.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 9:28 PM

btrahan accepted this revision.May 12 2014, 9:28 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 12 2014, 9:28 PM

Harbormaster completed remote builds in B409: Diff 21584.May 12 2014, 9:29 PM

Closed by commit rP91eb751d6f3d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

externals/

javelin/

core/

Event.js

5 lines

Diff 21584

View Options

resources/celerity/map.php