Page MenuHomePhabricator
Differential D9072

Update .arclint in Phabricator for phutil-library lint
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 12:05 PM.
Tags
None
Referenced Files
F13327461: D9072.diff
Sat, Jun 15, 7:06 PM
F13290022: D9072.diff
Tue, Jun 4, 3:23 PM
F13255923: D9072.id.diff
Sat, May 25, 9:10 AM
F13255472: D9072.id21545.diff
Sat, May 25, 5:30 AM
F13253238: D9072.diff
Sat, May 25, 2:31 AM
F13242157: D9072.id21545.diff
Thu, May 23, 1:59 AM
F13232092: D9072.diff
Tue, May 21, 1:00 AM
F13210956: D9072.diff
May 17 2024, 5:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Commits
Restricted Diffusion Commit
rP23487dc35768: Update .arclint in Phabricator for phutil-library lint
Summary

Also fix a few other minor issues:

  • Use lint config.
  • Fix a method signature from arc unit --everything (unrelated).
  • Add a javelin doc.
Test Plan

Ran arc lint, arc unit, arc linters.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21545.May 12 2014, 12:05 PM
epriestley retitled this revision from to Update .arclint in Phabricator for phutil-library lint.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 12:05 PM
Harbormaster completed remote builds in B395: Diff 21545.May 12 2014, 12:06 PM
joshuaspence accepted this revision.May 12 2014, 12:59 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 12:59 PM
epriestley closed this revision.May 12 2014, 1:01 PM
epriestley updated this revision to Diff 21550.

Closed by commit rP23487dc35768 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
4 lines
24 lines
src/
2 lines
infrastructure/
lint/
linter/
11 lines
sms/
worker/
2 lines

Diff 21550

View Options

.arcconfig

Loading...
View Options

.arclint

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/infrastructure/lint/linter/PhabricatorJavelinLinter.php

Loading...
View Options

src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php

Loading...
Phabricator · Built by Phacility