Page MenuHomePhabricator
Differential D9069

Make the `PhutilLintEngine` final.
ClosedPublic
Actions

Authored by joshuaspence on May 12 2014, 10:34 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCc4ac8a1aea26: Make the `PhutilLintEngine` final.
Summary

Phabricator now uses the ArcanistConfigurationDrivenLintEngine lint
engine instead of the PhabricatorLintEngine lint engine.

Depends on D9064.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
final-phutil-engine
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 392
Build 392: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21536.May 12 2014, 10:34 AM
joshuaspence retitled this revision from to Make the `PhutilLintEngine` final..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D9064: Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2014, 10:34 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B392: Diff 21536.May 12 2014, 10:35 AM
epriestley accepted this revision.May 12 2014, 11:30 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 11:30 AM
epriestley closed this revision.May 12 2014, 11:31 AM
epriestley updated this revision to Diff 21538.

Closed by commit rARCc4ac8a1aea26 (authored by @joshuaspence, committed by @epriestley).

joshuaspence added a comment.May 12 2014, 11:36 AM

Hmm, this depends on D9064... which hasn't been closed yet.

Revision Contents
Changeset List

PathSize
src/
lint/
engine/
6 lines

Diff 21536

View Options

src/lint/engine/PhutilLintEngine.php

Loading...
Phabricator · Built by Phacility