Page MenuHomePhabricator

Make the methods of `ArcanistBaseXHPASTLinter` final.
ClosedPublic

Authored by joshuaspence on May 10 2014, 5:42 AM.
Tags
None
Referenced Files
F14022457: D9035.diff
Wed, Nov 6, 5:40 PM
F14018387: D9035.id21460.diff
Tue, Nov 5, 11:08 AM
F14012979: D9035.id21468.diff
Fri, Nov 1, 10:51 PM
F13972173: D9035.diff
Thu, Oct 17, 5:30 PM
F13972160: D9035.id.diff
Thu, Oct 17, 5:26 PM
F13972156: D9035.id21460.diff
Thu, Oct 17, 5:25 PM
F13972153: D9035.id21468.diff
Thu, Oct 17, 5:23 PM
F13972052: D9035.diff
Thu, Oct 17, 4:52 PM
Subscribers

Details

Summary

No subclass should need to override these methods. Additionally, none currently do.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
xhpast-final
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 338
Build 338: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Make the methods of `ArcanistBaseXHPASTLinter` final..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 10 2014, 8:51 AM
epriestley updated this revision to Diff 21468.

Closed by commit rARCd80468bf8152 (authored by @joshuaspence, committed by @epriestley).