Allow .arclint to configure max line length of text linter
ClosedPublic
Actions

Authored by • bitglue on May 9 2014, 6:21 PM.

Details

Reviewers

Group Reviewers

Blessed Reviewers
Arcanist

Commits

rARC88bb9909b956: Allow .arclint to configure max line length of text linter

Test Plan

Verified manually. Something like this in .arclint:

"linters" : {
  "text" : {
    "type" : "text",
    "include" : "(\\.(txt|py|html?)$)",
    "text.max-line-length": 200
  }

changes the line length. Something other than an integer there raises an error.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

• bitglue updated this revision to Diff 21444.May 9 2014, 6:21 PM

• bitglue retitled this revision from to Allow .arclint to configure max line length of text linter.

• bitglue updated this object.

• bitglue edited the test plan for this revision. (Show Details)

• bitglue added a reviewer: Arcanist.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 9 2014, 6:21 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B328: Diff 21444.May 9 2014, 6:22 PM

I'll accept this if you rename the option to text.max-line-length, to namespace it for the linter and keep it consistent with other available options.

This revision now requires changes to proceed.May 9 2014, 6:25 PM

make option name consistent with other options

Herald added a subscriber: Korvin. · View Herald TranscriptMay 9 2014, 6:30 PM

• bitglue edited the test plan for this revision. (Show Details)May 9 2014, 6:31 PM

• bitglue edited edge metadata.

Thanks!

This revision is now accepted and ready to land.May 9 2014, 6:31 PM

Harbormaster completed remote builds in B329: Diff 21445.May 9 2014, 6:31 PM

Closed by commit rARC88bb9909b956 (authored by @bitglue, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistTextLinter.php

18 lines

Diff 21446

View Options

src/lint/linter/ArcanistTextLinter.php

Allow .arclint to configure max line length of text linterClosedPublicActions