Page MenuHomePhabricator
Differential D9010

Move Slowvote rendering into SearchEngine
ClosedPublic
Actions

Authored by epriestley on May 8 2014, 3:45 PM.
Tags
None
Referenced Files
F13132351: D9010.diff
Wed, May 1, 6:53 PM
F13131209: D9010.id21424.diff
Wed, May 1, 3:05 PM
F13131208: D9010.id21399.diff
Wed, May 1, 3:05 PM
Unknown Object (File)
Sun, Apr 28, 7:35 AM
Unknown Object (File)
Wed, Apr 24, 10:07 PM
Unknown Object (File)
Fri, Apr 12, 11:04 AM
Unknown Object (File)
Thu, Apr 11, 7:43 AM
Unknown Object (File)
Mon, Apr 1, 11:01 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rP8f42f4b538b2: Move Slowvote rendering into SearchEngine
Summary

Ref T4986. This adds a bit of structure for handles, since we used to have Controller utilities but no longer do.

Hopefully these will start going faster soon...

Test Plan
  • Checked feed for collateral damage.
  • Checked slowvote for collateral damage.
  • Made a slowvote panel.

Screen_Shot_2014-05-08_at_8.40.41_AM.png (345×372 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21399.May 8 2014, 3:45 PM
epriestley retitled this revision from to Move Slowvote rendering into SearchEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 8 2014, 3:45 PM
Harbormaster completed remote builds in B301: Diff 21399.May 8 2014, 3:46 PM
btrahan accepted this revision.May 8 2014, 6:18 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 8 2014, 6:18 PM
epriestley closed this revision.May 9 2014, 3:04 AM
epriestley updated this revision to Diff 21424.

Closed by commit rP8f42f4b538b2 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
feed/
query/
5 lines
search/
engine/
25 lines
slowvote/
controller/
48 lines
query/
49 lines

Diff 21424

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteListController.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
Phabricator · Built by Phacility