Paths

Table of Contentst

Differential D8993

Parse JSON as an associate array.
ClosedPublic
Actions

Authored by joshuaspence on May 6 2014, 4:17 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC9a13c87ac4a9: Parse JSON as an associate array.

Summary

It seems that in some situations, JSHint does not set the evidence property. In such cases, PHP fails with Undefined property: stdClass::$evidence. It would be safer to access the error object as an associative array rather than as stdClass.

Test Plan

Ran arc lint over a file which (previously) caused the exception.

Diff Detail

Repository

rARC Arcanist

Branch

jshint

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 267
Build 267: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21353.May 6 2014, 4:17 AM

joshuaspence retitled this revision from to Parse JSON as an associate array..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2014, 4:17 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.May 6 2014, 4:18 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 6 2014, 4:18 AM

joshuaspence updated this object.May 6 2014, 4:18 AM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

Harbormaster completed remote builds in B267: Diff 21353.May 6 2014, 4:19 AM

Closed by commit rARC9a13c87ac4a9 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistJSHintLinter.php

16 lines

Diff 21353

View Options

src/lint/linter/ArcanistJSHintLinter.php

Parse JSON as an associate array.ClosedPublicActions