Page MenuHomePhabricator
Differential D8990

Add a `puppet-lint` linter.
ClosedPublic
Actions

Authored by joshuaspence on May 6 2014, 3:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 1:12 AM
Unknown Object (File)
Tue, Apr 2, 8:29 PM
Unknown Object (File)
Tue, Apr 2, 8:18 PM
Unknown Object (File)
Tue, Apr 2, 8:10 PM
Unknown Object (File)
Tue, Apr 2, 8:03 PM
Unknown Object (File)
Tue, Apr 2, 8:03 PM
Unknown Object (File)
Tue, Apr 2, 8:02 PM
Unknown Object (File)
Sun, Mar 31, 10:22 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC8523b98f396d: Add a `puppet-lint` linter.
Summary

This linter is a wrapper around puppet-lint.

Test Plan

Wrote an executed unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
puppet-lint
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 265
Build 265: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21347.May 6 2014, 3:26 AM
joshuaspence retitled this revision from to Add a `puppet-lint` linter..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2014, 3:26 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B263: Diff 21347.May 6 2014, 3:27 AM
epriestley requested changes to this revision.May 6 2014, 3:30 AM
epriestley edited edge metadata.

Minor technical nits, but the sprintf() seems like a leftover?

src/lint/linter/ArcanistPuppetLintLinter.php
46

sprintf('%s', ...) has no effect?

59

Maybe explode('|', $line, 5) to handle the case where %{message} contains | for some reason?

This revision now requires changes to proceed.May 6 2014, 3:30 AM
joshuaspence added inline comments.May 6 2014, 3:41 AM
src/lint/linter/ArcanistPuppetLintLinter.php
46

Yep, let me do this a better way.

59

Good catch.

joshuaspence updated this revision to Diff 21350.May 6 2014, 3:42 AM
joshuaspence edited edge metadata.

Minor changes.

epriestley accepted this revision.May 6 2014, 3:42 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 6 2014, 3:42 AM
epriestley closed this revision.May 6 2014, 3:42 AM
epriestley updated this revision to Diff 21351.

Closed by commit rARC8523b98f396d (authored by @joshuaspence, committed by @epriestley).

Harbormaster completed remote builds in B265: Diff 21350.May 6 2014, 3:43 AM
joshuaspence updated this object.May 6 2014, 3:58 AM
joshuaspence edited edge metadata.

Revision Contents
Changeset List

Diff 21350

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistPuppetLintLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPuppetLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/2sp_soft_tabs.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/arrow_alignment.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/double_quoted_strings.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/duplicate_params.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/ensure_not_symlink_target.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/file_mode.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/hard_tabs.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/names_containing_dash.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/quoted_booleans.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/right_to_left_relationship.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/site.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/slash_comments.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/star_comments.lint-test

Loading...
View Options

src/lint/linter/__tests__/puppet-lint/unquoted_file_mode.lint-test

Loading...
Phabricator · Built by Phacility