Page MenuHomePhabricator

Make two small fixes to the quoting feature
ClosedPublic

Authored by epriestley on May 5 2014, 6:21 PM.
Tags
None
Referenced Files
F13147854: D8983.diff
Fri, May 3, 6:01 PM
Unknown Object (File)
Wed, Apr 24, 10:08 PM
Unknown Object (File)
Thu, Apr 11, 1:57 PM
Unknown Object (File)
Thu, Apr 11, 7:46 AM
Unknown Object (File)
Sun, Apr 7, 11:00 PM
Unknown Object (File)
Fri, Apr 5, 1:35 AM
Unknown Object (File)
Mar 19 2024, 7:42 AM
Unknown Object (File)
Mar 19 2024, 7:42 AM
Subscribers

Details

Summary

Ref T4119.

  • Trim newlines off the quoted text before quoting it; otherwise we can end up with a staircase of ">" at the end of a quote.
  • Allow image macros to have leading whitespace, so multiple consecuitive quoted macros work properly.
Test Plan

I QUOTED MACROS A LOT OF TIMES

Diff Detail

Repository
rP Phabricator
Branch
quote1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 251
Build 251: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make two small fixes to the quoting feature.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.May 5 2014, 6:22 PM
epriestley updated this revision to Diff 21325.

Closed by commit rP85bc05be255e (authored by @epriestley).