Never try to run README as a commit hook
ClosedPublic
Actions

Authored by epriestley on May 5 2014, 3:43 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4960: Never try to run README as a commit hook

Commits

Restricted Diffusion Commit
rP74faacee4d4a: Never try to run README as a commit hook

Summary

Fixes T4960. Users chmod +x this, and then bash chokes on it.

Phabricator "owns" this file anyway, so there is no real ambiguity here: this should never be a hook script.

Test Plan

Did chmod +x README.
Made a commit.
Added z.sh, got blocked.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21306.May 5 2014, 3:43 PM

epriestley retitled this revision from to Never try to run README as a commit hook.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4960: Never try to run README as a commit hook.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2014, 3:43 PM

Harbormaster completed remote builds in B248: Diff 21306.May 5 2014, 3:44 PM

chad accepted this revision.May 5 2014, 4:30 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.May 5 2014, 4:30 PM

Closed by commit rP74faacee4d4a (authored by @epriestley).

Harbormaster edited this Differential Revision.May 5 2014, 8:53 PM

Harbormaster completed remote builds in B248: Diff 21306.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

14 lines

Diff 21313

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Never try to run README as a commit hookClosedPublicActions