Page MenuHomePhabricator

Never try to run README as a commit hook
ClosedPublic

Authored by epriestley on May 5 2014, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 19, 3:24 PM
Unknown Object (File)
Wed, Jun 18, 10:32 PM
Unknown Object (File)
Mon, Jun 16, 6:57 PM
Unknown Object (File)
Thu, Jun 5, 5:58 PM
Unknown Object (File)
Apr 21 2025, 10:41 AM
Unknown Object (File)
Apr 18 2025, 7:22 PM
Unknown Object (File)
Apr 18 2025, 7:17 PM
Unknown Object (File)
Apr 3 2025, 7:38 PM
Subscribers

Details

Summary

Fixes T4960. Users chmod +x this, and then bash chokes on it.

Phabricator "owns" this file anyway, so there is no real ambiguity here: this should never be a hook script.

Test Plan
  • Did chmod +x README.
  • Made a commit.
  • Added z.sh, got blocked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Never try to run README as a commit hook.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.May 5 2014, 4:30 PM
epriestley updated this revision to Diff 21313.

Closed by commit rP74faacee4d4a (authored by @epriestley).

Harbormaster completed remote builds in B248: Diff 21306.