Page MenuHomePhabricator

Make blockquotes use parent/child rules
ClosedPublic

Authored by epriestley on May 2 2014, 5:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 7:36 AM
Unknown Object (File)
Feb 24 2024, 5:09 PM
Unknown Object (File)
Feb 21 2024, 6:18 AM
Unknown Object (File)
Feb 5 2024, 3:20 AM
Unknown Object (File)
Feb 5 2024, 3:20 AM
Unknown Object (File)
Feb 5 2024, 1:10 AM
Unknown Object (File)
Feb 5 2024, 1:10 AM
Unknown Object (File)
Feb 5 2024, 1:10 AM
Subscribers

Details

Summary

Ref T4119. This makes blockquotes generally work better (lists, code blocks, and other block elements will continue to work inside them). Particularly, it makes inline replies inside of quoted blocks tend to work better.

This changes some edge cases of the semantics slightly, but overall the results should be more reasonable and consistent.

Test Plan

Screen_Shot_2014-05-02_at_10.24.27_AM.png (649×557 px, 30 KB)

Diff Detail

Repository
rPHU libphutil
Branch
subblock2
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/markup/engine/__tests__/remarkup/quotes.txt:9TXT3Line Too Long
Auto-Fixsrc/markup/engine/__tests__/remarkup/quotes.txt:10TXT9Trailing Whitespace at EOF
Unit
Tests Passed
Build Status
Buildable 202
Build 202: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make blockquotes use parent/child rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
  • Slightly simpler ruleset.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 7:08 PM
epriestley updated this revision to Diff 21310.

Closed by commit rPHU1e703ff15309 (authored by @epriestley).