Revert the global "not imported yet" warning in Diffusion until we have better support
ClosedPublic
Actions

Authored by epriestley on Apr 30 2014, 6:11 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rP366861f10660: Revert the global "not imported yet" warning in Diffusion until we have better…

Summary

Partially reverts D8903. This was hacky to begin with, but completely breaks if the filetree is enabled ($view is not an array).

Just toss it until we have a more structured way to insert it into the document properly. I don't think it's especially important (the Herald warning is way more important).

Test Plan

Multiple users reported that stuff is no longer broken.

Diff Detail

Repository

rP Phabricator

Branch

nowarn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 146
Build 146: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21149.Apr 30 2014, 6:11 PM

epriestley retitled this revision from to Revert the global "not imported yet" warning in Diffusion until we have better support.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 30 2014, 6:11 PM

Harbormaster completed remote builds in B146: Diff 21149.Apr 30 2014, 6:12 PM

btrahan accepted this revision.Apr 30 2014, 6:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 30 2014, 6:33 PM

Closed by commit rP366861f10660 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

42 lines

Diff 21149

View Options

src/applications/diffusion/controller/DiffusionController.php

Revert the global "not imported yet" warning in Diffusion until we have better supportClosedPublicActions