'cuz things fail a bunch until importing is done. Fixes T4094.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4094: Warn when a user runs a Herald rule against an importing, non-publishing or disabled repository
- Commits
- Restricted Diffusion Commit
rP7ed28dacb585: Diffusion + Herald - warn users if importing repository
set isImporting to return true. Browsed Diffusion and saw helpful warnings everywhere. Browse Herald transcript and saw a helpful warning
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/diffusion/controller/DiffusionController.php | ||
|---|---|---|
| 48–57 | Maybe throw (or at least phlog()) if we fail to insert? I don't see a cleaner way to do this right now, but it would be nice to get told if this breaks. (Maybe we eventually separate $crumbs out so that we can just prepend the message.) | |
| src/applications/diffusion/controller/DiffusionController.php | ||
|---|---|---|
| 48–57 | I was trying to be fairly clever here as not all pages will have crumbs, and the ones that don't tend not to need such a message. An example is the commit edit controller. I think maybe the best way is to explicitly build this warning on a per controller basis rather than automagically do it and show iff there is some crumbs UI. That said, I was torn on which would be easiest for the next developer, and the explicitly build version sounds like a pain. | |
Comment Actions
Ah, that makes sense. Yeah, I don't see a clean way to do this right now and it doesn't seem important enough to go on a rampage restructuring everything.