Added .phabricator-remarkup-embed-image to full size images as well
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4902: `size=full` images are block level, so the space next to them is clickable.
- Commits
- Restricted Diffusion Commit
rPb6fa4856d2e2: Making `size=full` images have a shadow and be inline-block so the space next…
Add an image e.g. {F123, size=full} and verify that it has a shadow and the space next to it isn't clickable
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- arcpatch-D8858
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 103 Build 103: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
This fix is correct, but let's give this a separate CSS class (like phabricator-remarkup-embed-image-full) which fixes the block styling but doesn't add the shadow? I think it's helpful to provide a "shadow = click it to see a bigger version" hint, and adding the shadow to the full size image limits some creative/intentional uses of images (like if you want to use an image as a fancy divider or something, I guess).
Comment Actions
My reasoning there is also pretty weak, so if you think I'm crazy and the shadow is desirable even in this case I'm open to keeping it.
Comment Actions
I agree that some kind of distinction is nice, but the shadows help images
to stand out. Not sure what an ideal solution would be.
Also, would it unreasonable to have an option for turning off the shadow,
for cases were people really don't want it?
Comment Actions
We already do full-sized images and memes without the shadow, would prefer to keep that consistency. The shadow is only to indicate “scaled/click for full-size”.
Comment Actions
(I'd be 100% onboard with effect=... or filter=... but it needs to have at least like 5 effects, and they all have to be completely useless.)
Comment Actions
- Adding new .phabricator-remarkup-embed-image-full so the shadow is not applied to it