Fix Differential transaction strengths
ClosedPublic
Actions

Authored by epriestley on Apr 24 2014, 9:40 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4899: Emails and history for Differential prefers "changed subscribers" over "accepted this revision"

Commits

Restricted Diffusion Commit
rP1b0d53ec650f: Fix Differential transaction strengths

Summary

Fixes T4899. Action strengths got lost somewhere along the way; actions like "Accepted" should be stronger than "Changed Subscribers".

Test Plan

Verified things sort as expected now, with major actions at the top.

Diff Detail

Repository

rP Phabricator

Branch

xstr

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 64
Build 64: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21015.Apr 24 2014, 9:40 PM

epriestley retitled this revision from to Fix Differential transaction strengths.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4899: Emails and history for Differential prefers "changed subscribers" over "accepted this revision".

Herald added a subscriber: epriestley. · View Herald TranscriptApr 24 2014, 9:40 PM

Harbormaster completed remote builds in B64: Diff 21015.Apr 24 2014, 9:41 PM

chad accepted this revision.Apr 24 2014, 10:09 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Apr 24 2014, 10:09 PM

Closed by commit rP1b0d53ec650f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialTransaction.php

15 lines

Diff 21015

View Options

src/applications/differential/storage/DifferentialTransaction.php

Fix Differential transaction strengthsClosedPublicActions