Fixes T3566 List of poll actions should include ability to close an open poll or reopen a closed poll.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rP9a827096a74a: Ability to close poll
Poll author should be able to close/reopen poll. Non-author should get policy screen when attempting to close/reopen poll.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- closepoll
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 49 Build 49: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Handful of minor inlines.
| src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php | ||
|---|---|---|
| 17 | You can remove this check -- $this->id will always be set. This check is only important for controllers which can both create and edit objects, but this one only edits them. | |
| 60–62 | You can just call $poll->getIsClosed() here and remove the $this->isClosed property. | |
| 66 | The default text for cancel buttons is "Cancel", so just remove this variable. | |
| 78 | This should send the user back to $close_uri, not "/". You can check this behavior with:
(With the Javascript dialog, "cancel" always just closes the dialog.) | |
Comment Actions
| src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php | ||
|---|---|---|
| 29 | (Looks unused.) | |