Page MenuHomePhabricator
Differential D8839

More resilient timeline icon layout
ClosedPublic
Actions

Authored by chad on Apr 22 2014, 9:22 PM.
Tags
None
Referenced Files
F13277171: D8839.id20973.diff
Fri, May 31, 8:47 AM
F13274641: D8839.diff
Fri, May 31, 3:56 AM
F13260178: D8839.diff
Sun, May 26, 11:34 PM
F13244242: D8839.diff
Thu, May 23, 4:38 AM
F13236218: D8839.id20974.diff
Tue, May 21, 8:46 AM
F13223414: D8839.diff
Sun, May 19, 4:35 AM
F13219288: D8839.id20973.diff
Sat, May 18, 5:05 PM
Unknown Object (File)
Fri, May 3, 9:04 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4866: List of more-doughy-than-desirable transaction icons
Commits
Restricted Diffusion Commit
rP9d3f8117e738: More resilient timeline icon layout
Summary

center aligns the icons in the fill area, removes some of the positioning jank. Also set new icons for maniphest custom.

Test Plan

test desktop and mobile layouts, tested thin pins for proper centering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 20973.Apr 22 2014, 9:22 PM
chad retitled this revision from to More resilient timeline icon layout.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptApr 22 2014, 9:22 PM
Harbormaster completed remote builds in B42: Diff 20973.Apr 22 2014, 9:23 PM
epriestley accepted this revision.Apr 22 2014, 9:23 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2014, 9:23 PM
chad closed this revision.Apr 22 2014, 9:24 PM
chad updated this revision to Diff 20974.

Closed by commit rP9d3f8117e738 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
differential/
storage/
6 lines
maniphest/
config/
6 lines
storage/
3 lines
webroot/
rsrc/
css/
phui/
14 lines

Diff 20974

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility